[
https://issues.apache.org/jira/browse/HIVE-25200?focusedWorklogId=607728&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-607728
]
ASF GitHub Bot logged work on HIVE-25200:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 07/Jun/21 09:18
Start Date: 07/Jun/21 09:18
Worklog Time Spent: 10m
Work Description: marton-bod commented on a change in pull request #2351:
URL: https://github.com/apache/hive/pull/2351#discussion_r646413108
##########
File path:
iceberg/iceberg-catalog/src/main/java/org/apache/iceberg/hive/HiveSchemaUtil.java
##########
@@ -134,6 +136,28 @@ public static Type convert(TypeInfo typeInfo) {
return HiveSchemaConverter.convert(typeInfo, false);
}
+ /**
+ * Produces the difference of two FieldSchema lists by only taking into
account the field name and type.
+ * @param from List of fields to subtract from
+ * @param to List of fields to subtract
+ * @return the result list of difference
+ */
+ public static List<FieldSchema> schemaDifference(List<FieldSchema> from,
List<FieldSchema> to) {
Review comment:
These parameter names suggest to me that `to` represent some destination
collection, and `from` is the source collection. Can we rename them a bit?
Maybe something like `baseFields` and `fieldsToRemove`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 607728)
Time Spent: 1h 40m (was: 1.5h)
> Alter table add columns support for Iceberg tables
> --------------------------------------------------
>
> Key: HIVE-25200
> URL: https://issues.apache.org/jira/browse/HIVE-25200
> Project: Hive
> Issue Type: Improvement
> Reporter: Ádám Szita
> Assignee: Ádám Szita
> Priority: Major
> Labels: pull-request-available
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
> Since Iceberg counts as being a non-native Hive table, addColumn operation
> needs to be implemented by the help of Hive meta hooks.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
