[ 
https://issues.apache.org/jira/browse/HIVE-25272?focusedWorklogId=614341&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-614341
 ]

ASF GitHub Bot logged work on HIVE-25272:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 24/Jun/21 06:31
            Start Date: 24/Jun/21 06:31
    Worklog Time Spent: 10m 
      Work Description: pkumarsinha commented on a change in pull request #2413:
URL: https://github.com/apache/hive/pull/2413#discussion_r657662547



##########
File path: ql/src/java/org/apache/hadoop/hive/ql/io/AcidUtils.java
##########
@@ -182,10 +183,20 @@ public boolean accept(Path path) {
   public static final int MAX_STATEMENTS_PER_TXN = 10000;
   public static final Pattern LEGACY_BUCKET_DIGIT_PATTERN = 
Pattern.compile("^[0-9]{6}");
   public static final Pattern BUCKET_PATTERN = 
Pattern.compile("bucket_([0-9]+)(_[0-9]+)?$");
+  private static final Set<Integer> READ_TXN_TOKENS = new HashSet<Integer>();
 
   private static Cache<String, DirInfoValue> dirCache;
   private static AtomicBoolean dirCacheInited = new AtomicBoolean();
 
+  static {
+    READ_TXN_TOKENS.addAll(Arrays.asList(

Review comment:
       Yes, they are covered




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 614341)
    Time Spent: 2h 40m  (was: 2.5h)

> READ transactions are getting logged in NOTIFICATION LOG
> --------------------------------------------------------
>
>                 Key: HIVE-25272
>                 URL: https://issues.apache.org/jira/browse/HIVE-25272
>             Project: Hive
>          Issue Type: Bug
>            Reporter: Pravin Sinha
>            Assignee: Pravin Sinha
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 2h 40m
>  Remaining Estimate: 0h
>
> While READ transactions are already skipped from getting logged in 
> NOTIFICATION logs, few are still getting logged. Need to skip those 
> transactions as well.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to