[ 
https://issues.apache.org/jira/browse/HIVE-25250?focusedWorklogId=614421&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-614421
 ]

ASF GitHub Bot logged work on HIVE-25250:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 24/Jun/21 09:51
            Start Date: 24/Jun/21 09:51
    Worklog Time Spent: 10m 
      Work Description: ashish-kumar-sharma edited a comment on pull request 
#2404:
URL: https://github.com/apache/hive/pull/2404#issuecomment-867501246


   @kgyrtkirk  Thank you for the quick  reply.
   
   When I did some changes in date_format UDF (HIVE-25093) and push the PR. In 
hive-precommit test only test which was failling is 
TestHS2ImpersonationWithRemoteMS.testImpersonation. After investigation I found 
that it has no relation with UDF but the test it self was flaky. So instead of 
created an new jira and raising a new PR for fixing 
TestHS2ImpersonationWithRemoteMS.testImpersonation. I fixed it as part of 
date_format UDF(HIVE-25093). Before (HIVE-25093) get merged you created new 
jira (HIVE-25250) and marked the test ignored and merged to master. 
   
   Now coming to why test failed. In test testImpersonation it try to connect 
to miniHs2. 
   
   DriverManager.getConnection(miniHS2.getJdbcURL(), "foo", null);   
   
   Since this is a network call there is a retry in place to avoid unwanted 
network failers. So we have a variable ("maxRetries") which control the number 
of retries and default value of which was "1" and that variable can be 
overridden by passing "maxRetries={somevalue}" as part of jdbc URL. Since 
default value "maxRetries=1" is very less. So I changed it to "maxRetries=5" as 
part of (HIVE-25093). But since you have marked this ignored so I am rasing 
this PR to uncomment the test and "maxRetries=5" seems to be at higher side. So 
I am making it maxRetries=3" and uncommenting the test.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 614421)
    Time Spent: 1h 20m  (was: 1h 10m)

> Fix TestHS2ImpersonationWithRemoteMS.testImpersonation
> ------------------------------------------------------
>
>                 Key: HIVE-25250
>                 URL: https://issues.apache.org/jira/browse/HIVE-25250
>             Project: Hive
>          Issue Type: Bug
>            Reporter: Zoltan Haindrich
>            Assignee: Ashish Sharma
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 1h 20m
>  Remaining Estimate: 0h
>
> http://ci.hive.apache.org/job/hive-flaky-check/235/testReport/org.apache.hive.service/TestHS2ImpersonationWithRemoteMS/testImpersonation/



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to