[ 
https://issues.apache.org/jira/browse/HIVE-25250?focusedWorklogId=614462&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-614462
 ]

ASF GitHub Bot logged work on HIVE-25250:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 24/Jun/21 12:24
            Start Date: 24/Jun/21 12:24
    Worklog Time Spent: 10m 
      Work Description: kgyrtkirk commented on pull request #2404:
URL: https://github.com/apache/hive/pull/2404#issuecomment-867594564


   you have modified the default value of retries inside  
`jdbc/src/java/org/apache/hive/jdbc/HiveConnection.java` in an unrelated 
changeset - and this changeset  follows that pattern;
   
   I think going from 5 to 3 would be okayish but going from 1 to anything else 
is not the same - because you will enable the retries by default.
   
   I don't think we should change things like that...that change should have 
done in a separate patch - because it have touched production code; and it 
changed the default behaviour as well.
   
   It seems like `maxRetries` is not documented here 
https://cwiki.apache.org/confluence/display/Hive/HiveServer2+Clients
   
   I think the correct approach is to set it back to 1 and change the retry 
number for the tests thru the jdbc url.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 614462)
    Time Spent: 1h 40m  (was: 1.5h)

> Fix TestHS2ImpersonationWithRemoteMS.testImpersonation
> ------------------------------------------------------
>
>                 Key: HIVE-25250
>                 URL: https://issues.apache.org/jira/browse/HIVE-25250
>             Project: Hive
>          Issue Type: Bug
>            Reporter: Zoltan Haindrich
>            Assignee: Ashish Sharma
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 1h 40m
>  Remaining Estimate: 0h
>
> http://ci.hive.apache.org/job/hive-flaky-check/235/testReport/org.apache.hive.service/TestHS2ImpersonationWithRemoteMS/testImpersonation/



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to