[ 
https://issues.apache.org/jira/browse/HIVE-25792?focusedWorklogId=694940&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-694940
 ]

ASF GitHub Bot logged work on HIVE-25792:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 13/Dec/21 10:11
            Start Date: 13/Dec/21 10:11
    Worklog Time Spent: 10m 
      Work Description: pvary commented on a change in pull request #2865:
URL: https://github.com/apache/hive/pull/2865#discussion_r767580354



##########
File path: ql/src/java/org/apache/hadoop/hive/ql/HookRunner.java
##########
@@ -121,19 +121,27 @@ void runBeforeCompileHook(String command) {
   }
 
   /**
-  * Dispatches {@link QueryLifeTimeHook#afterCompile(QueryLifeTimeHookContext, 
boolean)}.
-  *
-  * @param command the Hive command that is being run
-  * @param compileError true if there was an error while compiling the 
command, false otherwise
-  */
-  void runAfterCompilationHook(String command, boolean compileError) {
+   * Dispatches {@link 
QueryLifeTimeHook#afterCompile(QueryLifeTimeHookContext, boolean)}.
+   *
+   * @param driverContext the DriverContext used for generating the HookContext
+   * @param analyzerContext the SemanticAnalyzer context for this query
+   * @param compileException the exception if one was thrown during the 
compilation
+   */
+  void runAfterCompilationHook(DriverContext driverContext, Context 
analyzerContext, Throwable compileException) {

Review comment:
       This is the original code from `Executor`:
   ```
         hookContext = new PrivateHookContext(driverContext.getPlan(), 
driverContext.getQueryState(),
             context.getPathToCS(), SessionState.get().getUserName(), 
SessionState.get().getUserIpAddress(),
             InetAddress.getLocalHost().getHostAddress(), 
driverContext.getOperationId(),
             SessionState.get().getSessionId(), 
Thread.currentThread().getName(), SessionState.get().isHiveServerQuery(),
             SessionState.getPerfLogger(), driverContext.getQueryInfo(), 
context);
   ```
   
   This uses `context`, and `driverContext`. Any idea how to replace the usage?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Issue Time Tracking
-------------------

    Worklog Id:     (was: 694940)
    Time Spent: 40m  (was: 0.5h)

> Multi Insert query fails on CBO path 
> -------------------------------------
>
>                 Key: HIVE-25792
>                 URL: https://issues.apache.org/jira/browse/HIVE-25792
>             Project: Hive
>          Issue Type: Bug
>            Reporter: Zoltan Haindrich
>            Assignee: Peter Vary
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 40m
>  Remaining Estimate: 0h
>
> {code}
> set hive.cbo.enable=true;
> drop table if exists aa1;
> drop table if exists bb1;
> drop table if exists cc1;
> drop table if exists dd1;
> drop table if exists ee1;
> drop table if exists ff1;
> create table aa1 ( stf_id string);
> create table bb1 ( stf_id string);
> create table cc1 ( stf_id string);
> create table ff1 ( x string);
> explain
> from ff1 as a join cc1 as b 
> insert overwrite table aa1 select   stf_id GROUP BY b.stf_id
> insert overwrite table bb1 select b.stf_id GROUP BY b.stf_id
> ;
> {code}



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

Reply via email to