[
https://issues.apache.org/jira/browse/HIVE-25822?focusedWorklogId=698491&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-698491
]
ASF GitHub Bot logged work on HIVE-25822:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 20/Dec/21 08:05
Start Date: 20/Dec/21 08:05
Worklog Time Spent: 10m
Work Description: kgyrtkirk commented on a change in pull request #2891:
URL: https://github.com/apache/hive/pull/2891#discussion_r772151007
##########
File path:
ql/src/java/org/apache/hadoop/hive/ql/exec/CommonMergeJoinOperator.java
##########
@@ -302,7 +322,47 @@ public void process(Object row, int tag) throws
HiveException {
assert !nextKeyGroup;
candidateStorage[tag].addRow(value);
+ }
+
+ private void emitExtensionRow(int tag, List<Object> value) throws
HiveException {
+ extensionStorage[tag].addRow(value);
+ for (byte i = 0; i < order.length; i++) {
+ if (i == tag) {
+ storage[i] = extensionStorage[i];
+ } else {
+ putDummyOrEmpty(i);
+ }
+ }
+ checkAndGenObject();
+ extensionStorage[tag].clearRows();
+ }
+ /**
+ * Decides if the actual row must be an extension row.
+ *
+ * Extension rows are those which are not part of the inner-join.
+ * May not correctly identify all extension rows - but will remove trivially
filtered ones.
Review comment:
> May not identify all extension rows
it could not identify non-trivial ones like that no rows could satisfy the
`l.id=r.id and l.id+2*r.id=1` condition...
guess what...running:
```
select * from t_xy l full outer join t_y r on (l.id=r.id and l.s='y' and
l.id+2*r.id=1);
```
resulted in incorrect results as well...
this will leave me no choice but to remove that `skip` crap and replace it
with something decent....
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 698491)
Time Spent: 40m (was: 0.5h)
> Incorrect False positive result rows may be outputted in case outer join has
> conditions only affecting one side
> ---------------------------------------------------------------------------------------------------------------
>
> Key: HIVE-25822
> URL: https://issues.apache.org/jira/browse/HIVE-25822
> Project: Hive
> Issue Type: Improvement
> Reporter: Zoltan Haindrich
> Assignee: Zoltan Haindrich
> Priority: Major
> Labels: pull-request-available
> Time Spent: 40m
> Remaining Estimate: 0h
>
> needed
> * outer join
> * on condition has at least one condition for one side of the join
> * in a single reducer:
> ** a right hand side only row outputted right before
> ** >=2 rows on LHS and 1 on RHS matching in the join keys but the first LHS
> doesn't satisfies the filter condition
> ** second LHS row with good filter condition
> {code}
> with
> t_y as (select col1 as id,col2 as s from (VALUES(0,'a'),(1,'y')) as c),
> t_xy as (select col1 as id,col2 as s from (VALUES(1,'x'),(1,'y')) as c)
> select * from t_xy l full outer join t_y r on (l.id=r.id and l.s='y');
> {code}
> null,null,1,y is a false positive result
> {code}
> +-------+-------+-------+-------+
> | l.id | l.s | r.id | r.s |
> +-------+-------+-------+-------+
> | NULL | NULL | 0 | a |
> | 1 | x | NULL | NULL |
> | NULL | NULL | 1 | y |
> | 1 | y | 1 | y |
> +-------+-------+-------+-------+
> {code}
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
