[
https://issues.apache.org/jira/browse/HIVE-25822?focusedWorklogId=699299&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-699299
]
ASF GitHub Bot logged work on HIVE-25822:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 21/Dec/21 10:49
Start Date: 21/Dec/21 10:49
Worklog Time Spent: 10m
Work Description: kgyrtkirk commented on a change in pull request #2891:
URL: https://github.com/apache/hive/pull/2891#discussion_r773030708
##########
File path:
ql/src/java/org/apache/hadoop/hive/ql/exec/CommonMergeJoinOperator.java
##########
@@ -240,6 +249,17 @@ public void process(Object row, int tag) throws
HiveException {
byte alias = (byte) tag;
List<Object> value = getFilteredValue(alias, row);
+
+ if (shortcutExtensionRows && isOuterJoinExtensionRow(tag, value)) {
+ int type = condn[0].getType();
+ if (tag == 0 && (type == JoinDesc.LEFT_OUTER_JOIN || type ==
JoinDesc.FULL_OUTER_JOIN)) {
+ emitExtensionRow(tag, value);
Review comment:
it have stopped for me for other outer joins ; however I had to disable
auto.join.converion to have that - without that the join was converted into a
mapjoin
I will make some further tests for different types of joins to see if we
don't have any issues
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 699299)
Time Spent: 1h 40m (was: 1.5h)
> Incorrect False positive result rows may be outputted in case outer join has
> conditions only affecting one side
> ---------------------------------------------------------------------------------------------------------------
>
> Key: HIVE-25822
> URL: https://issues.apache.org/jira/browse/HIVE-25822
> Project: Hive
> Issue Type: Bug
> Reporter: Zoltan Haindrich
> Assignee: Zoltan Haindrich
> Priority: Major
> Labels: pull-request-available
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
> needed
> * outer join
> * on condition has at least one condition for one side of the join
> * in a single reducer:
> ** a right hand side only row outputted right before
> ** >=2 rows on LHS and 1 on RHS matching in the join keys but the first LHS
> doesn't satisfies the filter condition
> ** second LHS row with good filter condition
> {code}
> with
> t_y as (select col1 as id,col2 as s from (VALUES(0,'a'),(1,'y')) as c),
> t_xy as (select col1 as id,col2 as s from (VALUES(1,'x'),(1,'y')) as c)
> select * from t_xy l full outer join t_y r on (l.id=r.id and l.s='y');
> {code}
> null,null,1,y is a false positive result
> {code}
> +-------+-------+-------+-------+
> | l.id | l.s | r.id | r.s |
> +-------+-------+-------+-------+
> | NULL | NULL | 0 | a |
> | 1 | x | NULL | NULL |
> | NULL | NULL | 1 | y |
> | 1 | y | 1 | y |
> +-------+-------+-------+-------+
> {code}
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
