[
https://issues.apache.org/jira/browse/HIVE-26102?focusedWorklogId=752931&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-752931
]
ASF GitHub Bot logged work on HIVE-26102:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 05/Apr/22 14:52
Start Date: 05/Apr/22 14:52
Worklog Time Spent: 10m
Work Description: marton-bod commented on code in PR #3131:
URL: https://github.com/apache/hive/pull/3131#discussion_r842882389
##########
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergOutputCommitter.java:
##########
@@ -156,11 +163,19 @@ public void abortTask(TaskAttemptContext originalContext)
throws IOException {
TaskAttemptContext context =
TezUtil.enrichContextWithAttemptWrapper(originalContext);
// Clean up writer data from the local store
- Map<String, HiveIcebergRecordWriter> writers =
HiveIcebergRecordWriter.removeWriters(context.getTaskAttemptID());
+ Map<String, HiveIcebergWriter> writers =
HiveIcebergWriter.getRecordWriters(context.getTaskAttemptID());
Review Comment:
We could move the logic to a static method in the writer, e.g.
`HiveIcebergWriter.closeAndRemoveWriters(attemptId)`. Is this what you had in
mind? This way we could call this static method in both `commitTask` and
`abortTask`.
Actually I don't see the writer closing logic in the `commitTask` method
currently (only in `abortTask`), so it's possible we're not even closing out
our iceberg writers currently in the happy path?
Issue Time Tracking
-------------------
Worklog Id: (was: 752931)
Time Spent: 4h 40m (was: 4.5h)
> Implement DELETE statements for Iceberg tables
> ----------------------------------------------
>
> Key: HIVE-26102
> URL: https://issues.apache.org/jira/browse/HIVE-26102
> Project: Hive
> Issue Type: New Feature
> Reporter: Marton Bod
> Assignee: Marton Bod
> Priority: Major
> Labels: pull-request-available
> Time Spent: 4h 40m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
