[
https://issues.apache.org/jira/browse/HIVE-26102?focusedWorklogId=753227&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-753227
]
ASF GitHub Bot logged work on HIVE-26102:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 06/Apr/22 07:20
Start Date: 06/Apr/22 07:20
Worklog Time Spent: 10m
Work Description: pvary commented on code in PR #3131:
URL: https://github.com/apache/hive/pull/3131#discussion_r843558677
##########
ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java:
##########
@@ -7822,9 +7824,18 @@ protected Operator genFileSinkPlan(String dest, QB qb,
Operator input)
List<ColumnInfo> vecCol = new ArrayList<ColumnInfo>();
- if (updating(dest) || deleting(dest)) {
+ boolean nonNativeAcid = Optional.ofNullable(destinationTable)
+ .map(Table::getStorageHandler)
+ .map(HiveStorageHandler::supportsAcidOperations)
+ .orElse(false);
+ boolean isUpdateDelete = updating(dest) || deleting(dest);
+ if (!nonNativeAcid && isUpdateDelete) {
Review Comment:
Is it a valid situation that: isUpdateDelete and we need to go to the `else`?
If not it might be easier to read:
```
if (updating(dest) || deleting(dest)) {
if (nonNativeAcid) {
...
} else {
...
} else {
..
}
```
Issue Time Tracking
-------------------
Worklog Id: (was: 753227)
Time Spent: 5h 40m (was: 5.5h)
> Implement DELETE statements for Iceberg tables
> ----------------------------------------------
>
> Key: HIVE-26102
> URL: https://issues.apache.org/jira/browse/HIVE-26102
> Project: Hive
> Issue Type: New Feature
> Reporter: Marton Bod
> Assignee: Marton Bod
> Priority: Major
> Labels: pull-request-available
> Time Spent: 5h 40m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
