[
https://issues.apache.org/jira/browse/HIVE-26117?focusedWorklogId=754195&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-754195
]
ASF GitHub Bot logged work on HIVE-26117:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 07/Apr/22 15:47
Start Date: 07/Apr/22 15:47
Worklog Time Spent: 10m
Work Description: kasakrisz commented on code in PR #3179:
URL: https://github.com/apache/hive/pull/3179#discussion_r845281998
##########
ql/src/test/results/clientnegative/joinneg.q.out:
##########
@@ -1 +1 @@
-FAILED: SemanticException [Error 10004]: Line 6:12 Invalid table alias or
column reference 'b': (possible column names are: x.key, x.value, y.key,
y.value)
+FAILED: SemanticException [Error 10009]: Line 6:12 Invalid table alias 'b'
Review Comment:
The original error message was more informative.
##########
ql/src/test/results/clientpositive/llap/views_explain_ddl.q.out:
##########
@@ -305,7 +305,7 @@ TBLPROPERTIES (
ALTER TABLE db1.table2_n13 UPDATE STATISTICS
SET('numRows'='0','rawDataSize'='0' );
ALTER TABLE db1.table1_n19 UPDATE STATISTICS
SET('numRows'='0','rawDataSize'='0' );
-CREATE VIEW `db1`.`v3_n3` AS SELECT `t1`.`key`, `t1`.`value`, `t2`.`key` `k`
FROM `db1`.`table1_n19` `t1` JOIN `db1`.`table2_n13` `t2` ON `t1`.`key` =
`t2`.`key`;
+CREATE VIEW `db1`.`v3_n3` AS SELECT `t1`.`key`, `t1`.`value`, `t2`.`key` `k`
FROM `db1`.`table1_n19` `t1` JOIN `db1`.`table2_n13` `t2` ON t1.key = t2.key;
Review Comment:
View expanded text changed: quotation removed from table and column names in
join condition:
```
t1.key = t2.key
```
should remain
```
`t1`.`key` = `t2`.`key`
```
Issue Time Tracking
-------------------
Worklog Id: (was: 754195)
Time Spent: 20m (was: 10m)
> Remove 2 superfluous lines of code in genJoinRelNode
> ----------------------------------------------------
>
> Key: HIVE-26117
> URL: https://issues.apache.org/jira/browse/HIVE-26117
> Project: Hive
> Issue Type: Bug
> Components: CBO
> Reporter: Steve Carlin
> Priority: Minor
> Labels: pull-request-available
> Time Spent: 20m
> Remaining Estimate: 0h
>
> The code was rewritten to associate ASTNodes to RexNodes. Some code was left
> behind that doesn't add any value.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
