[ 
https://issues.apache.org/jira/browse/HIVE-26117?focusedWorklogId=755980&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-755980
 ]

ASF GitHub Bot logged work on HIVE-26117:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 12/Apr/22 19:21
            Start Date: 12/Apr/22 19:21
    Worklog Time Spent: 10m 
      Work Description: scarlin-cloudera commented on code in PR #3179:
URL: https://github.com/apache/hive/pull/3179#discussion_r848792532


##########
ql/src/test/results/clientpositive/llap/views_explain_ddl.q.out:
##########
@@ -305,7 +305,7 @@ TBLPROPERTIES (
 ALTER TABLE db1.table2_n13 UPDATE STATISTICS 
SET('numRows'='0','rawDataSize'='0' );
 ALTER TABLE db1.table1_n19 UPDATE STATISTICS 
SET('numRows'='0','rawDataSize'='0' );
 
-CREATE VIEW `db1`.`v3_n3` AS SELECT `t1`.`key`, `t1`.`value`, `t2`.`key` `k` 
FROM `db1`.`table1_n19` `t1` JOIN `db1`.`table2_n13` `t2` ON `t1`.`key` = 
`t2`.`key`;
+CREATE VIEW `db1`.`v3_n3` AS SELECT `t1`.`key`, `t1`.`value`, `t2`.`key` `k` 
FROM `db1`.`table1_n19` `t1` JOIN `db1`.`table2_n13` `t2` ON t1.key = t2.key;

Review Comment:
   Makes sense.  Didn't know what the unparsed translator does until now, 
thanks!





Issue Time Tracking
-------------------

    Worklog Id:     (was: 755980)
    Time Spent: 50m  (was: 40m)

> Remove 2 superfluous lines of code in genJoinRelNode
> ----------------------------------------------------
>
>                 Key: HIVE-26117
>                 URL: https://issues.apache.org/jira/browse/HIVE-26117
>             Project: Hive
>          Issue Type: Bug
>          Components: CBO
>            Reporter: Steve Carlin
>            Assignee: Steve Carlin
>            Priority: Minor
>              Labels: pull-request-available
>          Time Spent: 50m
>  Remaining Estimate: 0h
>
> The code was rewritten to associate ASTNodes to RexNodes.  Some code was left 
> behind that doesn't add any value.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

Reply via email to