[jira] [Work logged] (HIVE-26188) Query level cache and HMS local cache doesn't work locally and with Explain statements.

[ASF GitHub Bot (Jira)]

     [ 
https://issues.apache.org/jira/browse/HIVE-26188?focusedWorklogId=769178&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-769178
 ]

ASF GitHub Bot logged work on HIVE-26188:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 11/May/22 16:23
            Start Date: 11/May/22 16:23
    Worklog Time Spent: 10m 
      Work Description: kgyrtkirk commented on code in PR #3256:
URL: https://github.com/apache/hive/pull/3256#discussion_r870514334


##########
ql/src/java/org/apache/hadoop/hive/ql/parse/ExplainSemanticAnalyzer.java:
##########
@@ -282,4 +282,11 @@ public boolean skipAuthorization() {
     }
     return super.skipAuthorization();
   }
+
+  @Override
+  public void startAnalysis() {
+    if 
(conf.getBoolVar(HiveConf.ConfVars.HIVE_OPTIMIZE_HMS_QUERY_CACHE_ENABLED)) {
+      queryState.createHMSCache();

Review Comment:
   why don't we need to do this for the other analyzers?
   Shouldn't this be moved to some common place; like `BaseSemanticAnalyzer` or 
somewhere else?
   
   





Issue Time Tracking
-------------------

            Worklog Id:     (was: 769178)
    Remaining Estimate: 0h
            Time Spent: 10m

> Query level cache and HMS local cache doesn't work locally and with Explain 
> statements.
> ---------------------------------------------------------------------------------------
>
>                 Key: HIVE-26188
>                 URL: https://issues.apache.org/jira/browse/HIVE-26188
>             Project: Hive
>          Issue Type: Bug
>            Reporter: Soumyakanti Das
>            Assignee: Soumyakanti Das
>            Priority: Major
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> {{ExplainSemanticAnalyzer}} should override {{startAnalysis()}} method that 
> creates the query level cache. This is important because after 
> https://issues.apache.org/jira/browse/HIVE-25918, the HMS local cache only 
> works if the query level cache is also initialized.
> Also, {{data/conf/llap/hive-site.xml}} properties for the HMS cache are 
> incorrect which should be fixed to enable the cache during qtests.



--
This message was sent by Atlassian Jira
(v8.20.7#820007)