[
https://issues.apache.org/jira/browse/HIVE-26188?focusedWorklogId=769217&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-769217
]
ASF GitHub Bot logged work on HIVE-26188:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 11/May/22 17:54
Start Date: 11/May/22 17:54
Worklog Time Spent: 10m
Work Description: jfsii commented on code in PR #3256:
URL: https://github.com/apache/hive/pull/3256#discussion_r870597220
##########
ql/src/java/org/apache/hadoop/hive/ql/parse/ExplainSemanticAnalyzer.java:
##########
@@ -282,4 +282,11 @@ public boolean skipAuthorization() {
}
return super.skipAuthorization();
}
+
+ @Override
+ public void startAnalysis() {
+ if
(conf.getBoolVar(HiveConf.ConfVars.HIVE_OPTIMIZE_HMS_QUERY_CACHE_ENABLED)) {
+ queryState.createHMSCache();
Review Comment:
@kgyrtkirk I think the reason I initially did not have it for the other
analyzers is that I could not prove it was safe easily -
I.E. For DDL I could imagine maybe there are situations in which we do not
want the original metadata cached and we want to fetch the updated metadata
after modification.
Issue Time Tracking
-------------------
Worklog Id: (was: 769217)
Time Spent: 20m (was: 10m)
> Query level cache and HMS local cache doesn't work locally and with Explain
> statements.
> ---------------------------------------------------------------------------------------
>
> Key: HIVE-26188
> URL: https://issues.apache.org/jira/browse/HIVE-26188
> Project: Hive
> Issue Type: Bug
> Reporter: Soumyakanti Das
> Assignee: Soumyakanti Das
> Priority: Major
> Labels: pull-request-available
> Time Spent: 20m
> Remaining Estimate: 0h
>
> {{ExplainSemanticAnalyzer}} should override {{startAnalysis()}} method that
> creates the query level cache. This is important because after
> https://issues.apache.org/jira/browse/HIVE-25918, the HMS local cache only
> works if the query level cache is also initialized.
> Also, {{data/conf/llap/hive-site.xml}} properties for the HMS cache are
> incorrect which should be fixed to enable the cache during qtests.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
