[ 
https://issues.apache.org/jira/browse/HIVE-21160?focusedWorklogId=772731&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-772731
 ]

ASF GitHub Bot logged work on HIVE-21160:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 20/May/22 09:01
            Start Date: 20/May/22 09:01
    Worklog Time Spent: 10m 
      Work Description: kasakrisz commented on code in PR #2855:
URL: https://github.com/apache/hive/pull/2855#discussion_r877910989


##########
ql/src/test/org/apache/hadoop/hive/ql/lockmgr/TestDbTxnManager2.java:
##########
@@ -1565,7 +1565,7 @@ public void testWriteSetTracking10() throws Exception {
     driver.compileAndRespond("update tab1 set b = 7 where b=2", true);
     txnMgr2.acquireLocks(driver.getPlan(), ctx, "T2");
     List<ShowLocksResponseElement> locks = getLocks(txnMgr2);
-    Assert.assertEquals("Unexpected lock count", 2, locks.size());
+    Assert.assertEquals("Unexpected lock count", 3, locks.size());

Review Comment:
   Update branch was split to an insert and a delete to the same table. The 
number of locks increased because a side effect of the way Hive acquires locks 
when executing multi insert statements.





Issue Time Tracking
-------------------

    Worklog Id:     (was: 772731)
    Time Spent: 1h 10m  (was: 1h)

> Rewrite Update statement as Multi-insert and do Update split early
> ------------------------------------------------------------------
>
>                 Key: HIVE-21160
>                 URL: https://issues.apache.org/jira/browse/HIVE-21160
>             Project: Hive
>          Issue Type: Sub-task
>          Components: Transactions
>    Affects Versions: 3.0.0
>            Reporter: Eugene Koifman
>            Assignee: Krisztian Kasa
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 1h 10m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.20.7#820007)

Reply via email to