[
https://issues.apache.org/jira/browse/HIVE-21160?focusedWorklogId=776255&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-776255
]
ASF GitHub Bot logged work on HIVE-21160:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 31/May/22 11:43
Start Date: 31/May/22 11:43
Worklog Time Spent: 10m
Work Description: kasakrisz commented on code in PR #2855:
URL: https://github.com/apache/hive/pull/2855#discussion_r885533555
##########
ql/src/java/org/apache/hadoop/hive/ql/parse/MergeSemanticAnalyzer.java:
##########
@@ -470,8 +405,7 @@ private String handleUpdate(ASTNode
whenMatchedUpdateClause, StringBuilder rewri
rewrittenQueryStr.append(" AND
NOT(").append(deleteExtraPredicate).append(")");
}
if(!splitUpdateEarly) {
- rewrittenQueryStr.append("\n SORT BY ");
- rewrittenQueryStr.append(targetName).append(".ROW__ID ");
+ appendSortBy(rewrittenQueryStr, Collections.singletonList(targetName +
".ROW__ID "));
}
rewrittenQueryStr.append("\n");
Review Comment:
Hive already write the rewritten sql string to the log
https://github.com/apache/hive/blob/1e3e07c87e71dc16f05ad269b250d65ad7c02232/ql/src/java/org/apache/hadoop/hive/ql/parse/RewriteSemanticAnalyzer.java#L271
It is does not contains the transformations which is performed on the
reparsed Ast.
Issue Time Tracking
-------------------
Worklog Id: (was: 776255)
Time Spent: 2h 40m (was: 2.5h)
> Rewrite Update statement as Multi-insert and do Update split early
> ------------------------------------------------------------------
>
> Key: HIVE-21160
> URL: https://issues.apache.org/jira/browse/HIVE-21160
> Project: Hive
> Issue Type: Sub-task
> Components: Transactions
> Affects Versions: 3.0.0
> Reporter: Eugene Koifman
> Assignee: Krisztian Kasa
> Priority: Major
> Labels: pull-request-available
> Time Spent: 2h 40m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
