[
https://issues.apache.org/jira/browse/HIVE-26244?focusedWorklogId=773781&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-773781
]
ASF GitHub Bot logged work on HIVE-26244:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 23/May/22 22:20
Start Date: 23/May/22 22:20
Worklog Time Spent: 10m
Work Description: simhadri-g commented on code in PR #3307:
URL: https://github.com/apache/hive/pull/3307#discussion_r879908488
##########
ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java:
##########
@@ -13900,7 +13901,11 @@ private void addDbAndTabToOutputs(String[]
qualifiedTabName, TableType type,
for(Map.Entry<String,String> serdeMap :
storageFormat.getSerdeProps().entrySet()){
t.setSerdeParam(serdeMap.getKey(), serdeMap.getValue());
}
- outputs.add(new WriteEntity(t, WriteEntity.WriteType.DDL_NO_LOCK));
+ if (tblProps.get("created_with_ctas") == "true") {
+ outputs.add(new WriteEntity(t, WriteType.CTAS));
Review Comment:
In CreateTableOperation, DDLUtils.addIfAbsentByName would populate the
output only if it was missed in the SemanticAnalyzer stage.
So I think, removing this step in CreateTableOperation and retaining it only
in SemanticAnalyze would be fine.
Issue Time Tracking
-------------------
Worklog Id: (was: 773781)
Time Spent: 1h 40m (was: 1.5h)
> Implementing locking for concurrent ctas
> ----------------------------------------
>
> Key: HIVE-26244
> URL: https://issues.apache.org/jira/browse/HIVE-26244
> Project: Hive
> Issue Type: Improvement
> Reporter: Simhadri G
> Assignee: Simhadri G
> Priority: Major
> Labels: pull-request-available
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
