[
https://issues.apache.org/jira/browse/HIVE-26244?focusedWorklogId=777316&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-777316
]
ASF GitHub Bot logged work on HIVE-26244:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 02/Jun/22 07:22
Start Date: 02/Jun/22 07:22
Worklog Time Spent: 10m
Work Description: deniskuzZ commented on code in PR #3307:
URL: https://github.com/apache/hive/pull/3307#discussion_r887645373
##########
ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java:
##########
@@ -13910,7 +13911,13 @@ private void addDbAndTabToOutputs(String[]
qualifiedTabName, TableType type,
for(Map.Entry<String,String> serdeMap :
storageFormat.getSerdeProps().entrySet()){
t.setSerdeParam(serdeMap.getKey(), serdeMap.getValue());
}
- outputs.add(new WriteEntity(t, WriteEntity.WriteType.DDL_NO_LOCK));
+ if (tblProps != null &&
+ tblProps.get(TABLE_IS_CTAS) == "true" &&
Review Comment:
could we do `Boolean.parseBoolean(..)` instead of comparing with the string
Issue Time Tracking
-------------------
Worklog Id: (was: 777316)
Time Spent: 2h 20m (was: 2h 10m)
> Implementing locking for concurrent ctas
> ----------------------------------------
>
> Key: HIVE-26244
> URL: https://issues.apache.org/jira/browse/HIVE-26244
> Project: Hive
> Issue Type: Improvement
> Reporter: Simhadri G
> Assignee: Simhadri G
> Priority: Major
> Labels: pull-request-available
> Time Spent: 2h 20m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
