[ 
https://issues.apache.org/jira/browse/HIVE-26233?focusedWorklogId=774587&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-774587
 ]

ASF GitHub Bot logged work on HIVE-26233:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 25/May/22 14:40
            Start Date: 25/May/22 14:40
    Worklog Time Spent: 10m 
      Work Description: zabetak commented on code in PR #3295:
URL: https://github.com/apache/hive/pull/3295#discussion_r881741459


##########
ql/src/test/org/apache/hadoop/hive/ql/io/parquet/serde/TestParquetTimestampUtils.java:
##########
@@ -389,6 +390,26 @@ public void testIllegalInt64TimestampStrings() {
     verifyInt64TimestampValue("2262-04-11 23:47:16.854775808", 
LogicalTypeAnnotation.TimeUnit.NANOS, false);
   }
 
+  @Test
+  public void testTimestamp9999() {

Review Comment:
   How about something like the following:
   
   ```java
     private static Stream<String> generateTimestamps() {
       return Stream.concat(Stream.of("9999-12-31 23:59:59.999"), 
Stream.generate(new Supplier<String>() {
   ```





Issue Time Tracking
-------------------

    Worklog Id:     (was: 774587)
    Time Spent: 1h 50m  (was: 1h 40m)

> Problems reading back PARQUET timestamps above 10000 years
> ----------------------------------------------------------
>
>                 Key: HIVE-26233
>                 URL: https://issues.apache.org/jira/browse/HIVE-26233
>             Project: Hive
>          Issue Type: Bug
>            Reporter: Peter Vary
>            Assignee: Peter Vary
>            Priority: Major
>              Labels: backwards-compatibility, pull-request-available, 
> timestamp
>          Time Spent: 1h 50m
>  Remaining Estimate: 0h
>
> Timestamp values above year 10000 are not supported, but during the migration 
> from Hive2 to Hive3 some might appear because of TZ issues. We should be able 
> to at least read these tables before rewriting the data.
> For this we need to change the Timestamp.PRINT_FORMATTER, so no {{+}} sign is 
> appended to the timestamp if the year exceeds 4 digits.



--
This message was sent by Atlassian Jira
(v8.20.7#820007)

Reply via email to