[
https://issues.apache.org/jira/browse/HIVE-26233?focusedWorklogId=774820&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-774820
]
ASF GitHub Bot logged work on HIVE-26233:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 25/May/22 21:26
Start Date: 25/May/22 21:26
Worklog Time Spent: 10m
Work Description: zabetak commented on code in PR #3295:
URL: https://github.com/apache/hive/pull/3295#discussion_r882128671
##########
ql/src/test/org/apache/hadoop/hive/ql/io/parquet/serde/TestParquetTimestampsHive2Compatibility.java:
##########
@@ -79,6 +79,18 @@ void testWriteHive2ReadHive4UsingLegacyConversion(String
timestampString) {
assertEquals(timestampString, ts.toString());
}
+ /**
+ * Tests that timestamps written using Hive2 APIs are read correctly by
Hive4 APIs when legacy conversion is on.
+ */
+ @ParameterizedTest(name = "{0}")
+ @MethodSource("generateTimestamps")
+ void testWriteHive2ReadHive4UsingLegacyConversionWithZone(String
timestampString) {
+ String zoneId = "US/Pacific";
+ NanoTime nt = writeHive2(timestampString);
Review Comment:
Since there is no parameter in `writeHive2` for specifying the timezone I
think you will need to call `TimeZone.setDefault()` explicitly otherwise it
will not work.
Issue Time Tracking
-------------------
Worklog Id: (was: 774820)
Time Spent: 2h 10m (was: 2h)
> Problems reading back PARQUET timestamps above 10000 years
> ----------------------------------------------------------
>
> Key: HIVE-26233
> URL: https://issues.apache.org/jira/browse/HIVE-26233
> Project: Hive
> Issue Type: Bug
> Reporter: Peter Vary
> Assignee: Peter Vary
> Priority: Major
> Labels: backwards-compatibility, pull-request-available,
> timestamp
> Time Spent: 2h 10m
> Remaining Estimate: 0h
>
> Timestamp values above year 10000 are not supported, but during the migration
> from Hive2 to Hive3 some might appear because of TZ issues. We should be able
> to at least read these tables before rewriting the data.
> For this we need to change the Timestamp.PRINT_FORMATTER, so no {{+}} sign is
> appended to the timestamp if the year exceeds 4 digits.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
