[
https://issues.apache.org/jira/browse/HIVE-26244?focusedWorklogId=779800&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-779800
]
ASF GitHub Bot logged work on HIVE-26244:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 09/Jun/22 07:57
Start Date: 09/Jun/22 07:57
Worklog Time Spent: 10m
Work Description: deniskuzZ commented on code in PR #3307:
URL: https://github.com/apache/hive/pull/3307#discussion_r893190254
##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/TxnHandler.java:
##########
@@ -3087,7 +3090,24 @@ private void insertTxnComponents(long txnid, LockRequest
rqst, Connection dbConn
String tblName = normalizeCase(lc.getTablename());
String partName = normalizePartitionCase(lc.getPartitionname());
OperationType opType =
OperationType.fromDataOperationType(lc.getOperationType());
-
+ if (opType.getSqlConst().equals(OperationType.CTAS.getSqlConst())) {
Review Comment:
why do you even need to create locks for CTAS with this approach? that won't
work as select doesn't even use any locking and we shouldn't add one. Why can't
we stick to checkLock method and only check for Excl_Write and Exclusive locks
in case of CTAS operation?
Issue Time Tracking
-------------------
Worklog Id: (was: 779800)
Time Spent: 3.5h (was: 3h 20m)
> Implementing locking for concurrent ctas
> ----------------------------------------
>
> Key: HIVE-26244
> URL: https://issues.apache.org/jira/browse/HIVE-26244
> Project: Hive
> Issue Type: Improvement
> Reporter: Simhadri G
> Assignee: Simhadri G
> Priority: Major
> Labels: pull-request-available
> Time Spent: 3.5h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
