[
https://issues.apache.org/jira/browse/HIVE-26316?focusedWorklogId=781073&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-781073
]
ASF GitHub Bot logged work on HIVE-26316:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 14/Jun/22 10:22
Start Date: 14/Jun/22 10:22
Worklog Time Spent: 10m
Work Description: pvary commented on code in PR #3367:
URL: https://github.com/apache/hive/pull/3367#discussion_r896645398
##########
ql/src/java/org/apache/hadoop/hive/ql/exec/repl/OptimisedBootstrapUtils.java:
##########
@@ -201,19 +262,17 @@ public static Long createAndGetEventAckFile(Path
currentDumpPath, DumpMetaData d
}
/**
- * Prepares the table diff file, with tables modified post the specified
event id.
- * @param eventId the event id after which tables should be modified
+ * Returns list of notificationEvents starting from eventId that are related
to the database.
+ * @param eventId Starting eventId
* @param hiveDb the hive object
* @param work the load work
- * @param conf hive configuration
* @throws Exception
*/
- public static void prepareTableDiffFile(Long eventId, Hive hiveDb,
ReplLoadWork work, HiveConf conf)
- throws Exception {
- // Get the notification events.
+ public static List<NotificationEvent> getListOfNotificationEvents(Long
eventId, Hive hiveDb,
+
ReplLoadWork work) throws Exception {
List<NotificationEvent> notificationEvents =
- hiveDb.getMSC().getNextNotification(eventId - 1, -1, new
DatabaseAndTableFilter(work.dbNameToLoadIn, null))
- .getEvents();
+ hiveDb.getMSC().getNextNotification(eventId - 1, -1,
+ new DatabaseAndTableFilter(work.dbNameToLoadIn,
null)).getEvents();
Review Comment:
Are these only formatting changes? We usually try to avoid these, so
backporting changes are easier
Issue Time Tracking
-------------------
Worklog Id: (was: 781073)
Time Spent: 1h 10m (was: 1h)
> Handle dangling open txns on both src & tgt in unplanned failover.
> ------------------------------------------------------------------
>
> Key: HIVE-26316
> URL: https://issues.apache.org/jira/browse/HIVE-26316
> Project: Hive
> Issue Type: Sub-task
> Reporter: Haymant Mangla
> Assignee: Haymant Mangla
> Priority: Major
> Labels: pull-request-available
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
