[
https://issues.apache.org/jira/browse/HIVE-26316?focusedWorklogId=781074&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-781074
]
ASF GitHub Bot logged work on HIVE-26316:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 14/Jun/22 10:31
Start Date: 14/Jun/22 10:31
Worklog Time Spent: 10m
Work Description: pvary commented on code in PR #3367:
URL: https://github.com/apache/hive/pull/3367#discussion_r896652450
##########
ql/src/java/org/apache/hadoop/hive/ql/exec/repl/ReplDumpTask.java:
##########
@@ -751,18 +767,19 @@ private void fetchFailoverMetadata(Hive hiveDb) throws
HiveException, IOExceptio
work.setFailoverMetadata(fmd);
return;
}
- List<Long> txnsForDb = getOpenTxns(getTxnMgr().getValidTxns(excludedTxns),
work.dbNameOrPattern);
+ HiveTxnManager hiveTxnManager = getTxnMgr();
Review Comment:
This call is not that costly, and if we use a static import for
`ReplUtils.getOpenTxns` we would have a smaller change which is easier to review
Issue Time Tracking
-------------------
Worklog Id: (was: 781074)
Time Spent: 1h 20m (was: 1h 10m)
> Handle dangling open txns on both src & tgt in unplanned failover.
> ------------------------------------------------------------------
>
> Key: HIVE-26316
> URL: https://issues.apache.org/jira/browse/HIVE-26316
> Project: Hive
> Issue Type: Sub-task
> Reporter: Haymant Mangla
> Assignee: Haymant Mangla
> Priority: Major
> Labels: pull-request-available
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
