[
https://issues.apache.org/jira/browse/HIVE-25976?focusedWorklogId=784081&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-784081
]
ASF GitHub Bot logged work on HIVE-25976:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 23/Jun/22 08:52
Start Date: 23/Jun/22 08:52
Worklog Time Spent: 10m
Work Description: veghlaci05 commented on code in PR #3289:
URL: https://github.com/apache/hive/pull/3289#discussion_r904753607
##########
iceberg/iceberg-handler/src/test/java/org/apache/iceberg/mr/hive/TestHiveIcebergTimeTravel.java:
##########
@@ -50,10 +49,14 @@ public void testSelectAsOfTimestamp() throws IOException,
InterruptedException {
Assert.assertEquals(4, rows.size());
- AssertHelpers.assertThrows("should throw exception",
IllegalArgumentException.class,
- "java.lang.IllegalArgumentException: Cannot find a snapshot older than
1970-01-01", () -> {
- shell.executeStatement("SELECT * FROM customers FOR SYSTEM_TIME AS OF
'1970-01-01 00:00:00'");
- });
+ try {
Review Comment:
With the change the FetchTask now executed inside the transaction in the
Driver, and as a result, if an exception is thrown, it is wrapped by
CommandProcessorException. There is a follow-up task:
[HIVE-26348](https://issues.apache.org/jira/browse/HIVE-26348) to improve the
error message, because now the original reason is not shown to the user
Issue Time Tracking
-------------------
Worklog Id: (was: 784081)
Time Spent: 40m (was: 0.5h)
> Cleaner may remove files being accessed from a fetch-task-converted reader
> --------------------------------------------------------------------------
>
> Key: HIVE-25976
> URL: https://issues.apache.org/jira/browse/HIVE-25976
> Project: Hive
> Issue Type: Bug
> Reporter: Zoltan Haindrich
> Assignee: László Végh
> Priority: Major
> Labels: pull-request-available
> Attachments: fetch_task_conv_compactor_test.patch
>
> Time Spent: 40m
> Remaining Estimate: 0h
>
> in a nutshell the following happens:
> * query is compiled in fetch-task-converted mode
> * no real execution happens....but the locks are released
> * the HS2 is communicating with the client and uses the fetch-task to get the
> rows - which in this case will directly read files from the table's
> directory....
> * client sleeps between reads - so there is ample time for other events...
> * cleaner wakes up and removes some files....
> * in the next read the fetch-task encounters a read error...
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
