[jira] [Work logged] (HIVE-25976) Cleaner may remove files being accessed from a fetch-task-converted reader

[ASF GitHub Bot (Jira)]

Title: Message Title

ASF GitHub Bot added a worklog on HIVE-25976   veghlaci05 commented on code in PR #3289: URL: https://github.com/apache/hive/pull/3289#discussion_r908139462 ########## ql/src/java/org/apache/hadoop/hive/ql/optimizer/SimpleFetchOptimizer.java: ########## @@ -152,28 +152,32 @@ private FetchTask optimize(ParseContext pctx, String alias, TableScanOperator so } private boolean checkThreshold(FetchData data, int limit, ParseContext pctx) throws Exception { if (limit > 0) { if (data.hasOnlyPruningFilter()) { - /* partitioned table + query has only pruning filters */ - return true; - } else if (data.isPartitioned() == false && data.isFiltered() == false) { /* unpartitioned table + no filters */ return true; + boolean cachingEnabled = HiveConf.getBoolVar(pctx.getConf(), HiveConf.ConfVars.HIVEFETCHTASKCACHING); + if (!cachingEnabled) { + /* if caching is enabled we apply the treshold in all cases */ Review Comment: No, the if construct is fine, I moved this comment outside of the if block. It was placed poorly. Worklog entry: 10m logged by ASF GitHub Bot Change By: ASF GitHub Bot Time Spent: 1h 20m 1.5h Add Comment   This message was sent by Atlassian Jira (v8.20.10#820010-sha1:ace47f9)