[
https://issues.apache.org/jira/browse/HIVE-26021?focusedWorklogId=784085&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-784085
]
ASF GitHub Bot logged work on HIVE-26021:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 23/Jun/22 08:55
Start Date: 23/Jun/22 08:55
Worklog Time Spent: 10m
Work Description: zabetak commented on code in PR #3399:
URL: https://github.com/apache/hive/pull/3399#discussion_r904757984
##########
standalone-metastore/DEV-README:
##########
@@ -23,47 +23,34 @@ quick test can be done for the unit tests and more in depth
testing as part
of the checkin tests.
--------------------------------------------------------------------------------
-There are integration tests for testing installation and upgrade of the
+There are checkin tests for testing installation and upgrade of the
metastore on Derby, MySQL (actually MariaDB is used), Oracle, Postgres, and
SQLServer.
-Each ITest runs two tests, one that installs the latest version of the
+For each DB type we runs two tests, one that installs the latest version of the
database and one that installs the latest version minus one and then upgrades
the database.
-To run the tests you will need to explicitly turn on integration testing by
-setting skipITests variable to false. The tests rely on Docker so the latter
-needs to be installed and configured properly (e.g., memory more than 3.5GB).
-
-Run all tests:
-
-mvn verify -DskipITests=false -Dtest=nosuch
+The tests (except Derby) rely on Docker so the latter needs to be installed
and configured
+properly (e.g., memory more than 3.5GB).
Run a single test:
-mvn verify -DskipITests=false -Dit.test=ITestMysql -Dtest=nosuch
+mvn test -Dtest.groups=MetastoreCheckinTest -Dtest=ITestDerby
Supported databases for testing:
--Dit.test=ITestDerby
--Dit.test=ITestMysql
--Dit.test=ITestOracle
--Dit.test=ITestPostgres
--Dit.test=ITestMssql
+ITestDerby
Review Comment:
Good catch. I originally wanted to keep the same names but due to various
problems in CI I was forced to rename them to avoid introducing an ugly
workaround. I will fix this during merge!
Issue Time Tracking
-------------------
Worklog Id: (was: 784085)
Time Spent: 2h (was: 1h 50m)
> Change integration tests under DBInstallBase to regular unit tests
> ------------------------------------------------------------------
>
> Key: HIVE-26021
> URL: https://issues.apache.org/jira/browse/HIVE-26021
> Project: Hive
> Issue Type: Improvement
> Components: Tests
> Reporter: Stamatis Zampetakis
> Priority: Major
> Labels: pull-request-available
> Time Spent: 2h
> Remaining Estimate: 0h
>
> After HIVE-18588, some tests including those under
> [DBInstallBase|https://github.com/apache/hive/blob/1139c4b14db82a9e2316196819b35cfb713f34b5/standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/dbinstall/DbInstallBase.java]
> class have been marked as integration tests mainly to keep the test duration
> low.
> Nowadays, Hive developers rarely run all tests locally so separating between
> integration tests and unit tests does not provide a clear benefit. The
> separation adds maintenance cost and makes their execution more difficult
> scaring people away.
> The goal of this issue is to change the tests under {{DBInstallBase}} from
> "integration" tests back to regular unit tests and run them as part of the
> standard maven test phase without any fancy arguments.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
