[
https://issues.apache.org/jira/browse/HIVE-26021?focusedWorklogId=784089&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-784089
]
ASF GitHub Bot logged work on HIVE-26021:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 23/Jun/22 09:03
Start Date: 23/Jun/22 09:03
Worklog Time Spent: 10m
Work Description: zabetak commented on code in PR #3399:
URL: https://github.com/apache/hive/pull/3399#discussion_r904770029
##########
Jenkinsfile:
##########
@@ -279,15 +279,6 @@ reinit_metastore $dbType
time docker rm -f dev_$dbType || true
'''
}
- stage('verify') {
Review Comment:
In principle the tests in `verify` stage are more complete so could
potentially replace completely all the other stages.
However, I find the `init-metastore` stage still useful cause it launches
the various types of metastores using the hive-dev-box logic outside the unit
test framework (classpaths may be different etc). This is closer to how a
metastore is used in production so I think it is useful to have them as well.
Issue Time Tracking
-------------------
Worklog Id: (was: 784089)
Time Spent: 2h 10m (was: 2h)
> Change integration tests under DBInstallBase to regular unit tests
> ------------------------------------------------------------------
>
> Key: HIVE-26021
> URL: https://issues.apache.org/jira/browse/HIVE-26021
> Project: Hive
> Issue Type: Improvement
> Components: Tests
> Reporter: Stamatis Zampetakis
> Priority: Major
> Labels: pull-request-available
> Time Spent: 2h 10m
> Remaining Estimate: 0h
>
> After HIVE-18588, some tests including those under
> [DBInstallBase|https://github.com/apache/hive/blob/1139c4b14db82a9e2316196819b35cfb713f34b5/standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/dbinstall/DbInstallBase.java]
> class have been marked as integration tests mainly to keep the test duration
> low.
> Nowadays, Hive developers rarely run all tests locally so separating between
> integration tests and unit tests does not provide a clear benefit. The
> separation adds maintenance cost and makes their execution more difficult
> scaring people away.
> The goal of this issue is to change the tests under {{DBInstallBase}} from
> "integration" tests back to regular unit tests and run them as part of the
> standard maven test phase without any fancy arguments.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
