[
https://issues.apache.org/jira/browse/HIVE-26055?focusedWorklogId=786608&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-786608
]
ASF GitHub Bot logged work on HIVE-26055:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 30/Jun/22 14:09
Start Date: 30/Jun/22 14:09
Worklog Time Spent: 10m
Work Description: deniskuzZ commented on code in PR #3247:
URL: https://github.com/apache/hive/pull/3247#discussion_r911074669
##########
ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/sqlstd/SQLStdHiveAuthorizationValidator.java:
##########
@@ -80,15 +80,15 @@ public void checkPrivileges(HiveOperationType hiveOpType,
List<HivePrivilegeObje
// check privileges on input and output objects
List<String> deniedMessages = new ArrayList<String>();
- checkPrivileges(hiveOpType, inputHObjs, metastoreClient, userName,
IOType.INPUT, deniedMessages);
- checkPrivileges(hiveOpType, outputHObjs, metastoreClient, userName,
IOType.OUTPUT, deniedMessages);
+ checkPrivileges(hiveOpType, inputHObjs, metastoreClient, userName,
IOType.INPUT, deniedMessages, false);
+ checkPrivileges(hiveOpType, outputHObjs, metastoreClient, userName,
IOType.OUTPUT, deniedMessages, hiveOpType ==
HiveOperationType.ALTERTABLE_RENAME ? true: false);
Review Comment:
no need for a ternary operator here, just:
````
hiveOpType == HiveOperationType.ALTERTABLE_RENAME
````
Issue Time Tracking
-------------------
Worklog Id: (was: 786608)
Time Spent: 5.5h (was: 5h 20m)
> Fix the HivePrivilegesObjects for Alter table rename command
> ------------------------------------------------------------
>
> Key: HIVE-26055
> URL: https://issues.apache.org/jira/browse/HIVE-26055
> Project: Hive
> Issue Type: Bug
> Components: HiveServer2, Security
> Reporter: Sai Hemanth Gantasala
> Assignee: Sai Hemanth Gantasala
> Priority: Major
> Labels: pull-request-available
> Time Spent: 5.5h
> Remaining Estimate: 0h
>
> Fix the HivePrivilegeObjects for Alter table rename query in a way that it
> includes source table information in the output objects and destination table
> information in the input objects.
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
