[
https://issues.apache.org/jira/browse/HIVE-26055?focusedWorklogId=787120&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-787120
]
ASF GitHub Bot logged work on HIVE-26055:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 01/Jul/22 14:52
Start Date: 01/Jul/22 14:52
Worklog Time Spent: 10m
Work Description: saihemanth-cloudera commented on code in PR #3247:
URL: https://github.com/apache/hive/pull/3247#discussion_r912033165
##########
itests/util/src/main/java/org/apache/hadoop/hive/ql/hooks/VerifyOutputTableLocationSchemeIsFileHook.java:
##########
@@ -24,10 +24,10 @@ public class VerifyOutputTableLocationSchemeIsFileHook
implements ExecuteWithHoo
@Override
public void run(HookContext hookContext) {
- for (WriteEntity output : hookContext.getOutputs()) {
- if (output.getType() == WriteEntity.Type.TABLE) {
- String scheme =
output.getTable().getDataLocation().toUri().getScheme();
- Assert.assertTrue(output.getTable().getTableName() + " has a location
which has a " +
+ for (ReadEntity input : hookContext.getInputs()) {
Review Comment:
I changed it for the following reason:
The output list now has a source table(old table name) and destination
table(renamed table name). This class is used in the alter_table_location.q to
check the schema of renamed table file location.
renamed table's getDataLocation() would be null at this stage because we'll
be setting the table's location in the MetaStoreDefaultTransformer class in the
HMS during execution. HMS will set the new location with the same schema.
That's the reason why I have changed from outputs to inputs.
Issue Time Tracking
-------------------
Worklog Id: (was: 787120)
Time Spent: 6h 10m (was: 6h)
> Fix the HivePrivilegesObjects for Alter table rename command
> ------------------------------------------------------------
>
> Key: HIVE-26055
> URL: https://issues.apache.org/jira/browse/HIVE-26055
> Project: Hive
> Issue Type: Bug
> Components: HiveServer2, Security
> Reporter: Sai Hemanth Gantasala
> Assignee: Sai Hemanth Gantasala
> Priority: Major
> Labels: pull-request-available
> Time Spent: 6h 10m
> Remaining Estimate: 0h
>
> Fix the HivePrivilegeObjects for Alter table rename query in a way that it
> includes source table information in the output objects and destination table
> information in the input objects.
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
