[ 
https://issues.apache.org/jira/browse/HIVE-26385?focusedWorklogId=792238&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-792238
 ]

ASF GitHub Bot logged work on HIVE-26385:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 18/Jul/22 16:38
            Start Date: 18/Jul/22 16:38
    Worklog Time Spent: 10m 
      Work Description: pvary commented on code in PR #3430:
URL: https://github.com/apache/hive/pull/3430#discussion_r923583853


##########
ql/src/java/org/apache/hadoop/hive/ql/parse/MergeSemanticAnalyzer.java:
##########
@@ -297,15 +309,16 @@ private boolean handleCardinalityViolation(StringBuilder 
rewrittenQueryStr, ASTN
     //this is a tmp table and thus Session scoped and acid requires SQL 
statement to be serial in a
     // given session, i.e. the name can be fixed across all invocations
     String tableName = "merge_tmp_table";
+    List<String> sortKeys = columnAppender.getSortKeys();

Review Comment:
   Please talk with @lcspinter about the sorted Iceberg tables. How the 2 PR 
will work together.
   
   Thanks,
   Peter





Issue Time Tracking
-------------------

    Worklog Id:     (was: 792238)
    Time Spent: 20m  (was: 10m)

> Iceberg integration: Implement merge into iceberg table
> -------------------------------------------------------
>
>                 Key: HIVE-26385
>                 URL: https://issues.apache.org/jira/browse/HIVE-26385
>             Project: Hive
>          Issue Type: Improvement
>          Components: File Formats
>            Reporter: Krisztian Kasa
>            Assignee: Krisztian Kasa
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 4.0.0
>
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> {code}
> create external table target_ice(a int, b string, c int) partitioned by spec 
> (bucket(16, a), truncate(3, b)) stored by iceberg stored as orc tblproperties 
> ('format-version'='2');
> create table source(a int, b string, c int);
> ...
> merge into target_ice as t using source src ON t.a = src.a
> when matched and t.a > 100 THEN DELETE
> when matched then update set b = 'Merged', c = t.c + 10
> when not matched then insert values (src.a, src.b, src.c);
> {code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to