[
https://issues.apache.org/jira/browse/HIVE-26385?focusedWorklogId=792576&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-792576
]
ASF GitHub Bot logged work on HIVE-26385:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 19/Jul/22 10:44
Start Date: 19/Jul/22 10:44
Worklog Time Spent: 10m
Work Description: pvary commented on code in PR #3430:
URL: https://github.com/apache/hive/pull/3430#discussion_r924344226
##########
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/writer/WriterBuilder.java:
##########
@@ -95,7 +96,9 @@ public HiveIcebergWriter build() {
int currentSpecId = table.spec().specId();
int partitionId = attemptID.getTaskID().getId();
int taskId = attemptID.getId();
- String operationId = queryId + "-" + attemptID.getJobID();
+ Map<String, List<HiveIcebergWriter>> writers =
WriterRegistry.writers(attemptID);
+ int writerCount = writers == null ? 0 : writers.size();
+ String operationId = queryId + "-" + attemptID.getJobID() + "-" +
writerCount;
Review Comment:
What about adding a random UUID adding to this, or using an AtomicInteger?
Issue Time Tracking
-------------------
Worklog Id: (was: 792576)
Time Spent: 50m (was: 40m)
> Iceberg integration: Implement merge into iceberg table
> -------------------------------------------------------
>
> Key: HIVE-26385
> URL: https://issues.apache.org/jira/browse/HIVE-26385
> Project: Hive
> Issue Type: Improvement
> Components: File Formats
> Reporter: Krisztian Kasa
> Assignee: Krisztian Kasa
> Priority: Major
> Labels: pull-request-available
> Fix For: 4.0.0
>
> Time Spent: 50m
> Remaining Estimate: 0h
>
> {code}
> create external table target_ice(a int, b string, c int) partitioned by spec
> (bucket(16, a), truncate(3, b)) stored by iceberg stored as orc tblproperties
> ('format-version'='2');
> create table source(a int, b string, c int);
> ...
> merge into target_ice as t using source src ON t.a = src.a
> when matched and t.a > 100 THEN DELETE
> when matched then update set b = 'Merged', c = t.c + 10
> when not matched then insert values (src.a, src.b, src.c);
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
