[ 
https://issues.apache.org/jira/browse/HIVE-26397?focusedWorklogId=792663&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-792663
 ]

ASF GitHub Bot logged work on HIVE-26397:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 19/Jul/22 12:52
            Start Date: 19/Jul/22 12:52
    Worklog Time Spent: 10m 
      Work Description: pvary commented on code in PR #3445:
URL: https://github.com/apache/hive/pull/3445#discussion_r924463757


##########
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergStorageHandler.java:
##########
@@ -682,7 +740,7 @@ public static Schema schema(Configuration config) {
   }
 
   /**
-   * Stores the serializable table data in the configuration.
+   * Stores the serializable table data in the configuration

Review Comment:
   Why is this change?
   BTW Javadoc expect `.` at the end of the first sentence... at least I 
remember somewhere fighting with adding extra dots at the end of the lines 😄 





Issue Time Tracking
-------------------

    Worklog Id:     (was: 792663)
    Time Spent: 0.5h  (was: 20m)

> Honour Iceberg sort orders when writing a table
> -----------------------------------------------
>
>                 Key: HIVE-26397
>                 URL: https://issues.apache.org/jira/browse/HIVE-26397
>             Project: Hive
>          Issue Type: Improvement
>            Reporter: László Pintér
>            Assignee: László Pintér
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> Iceberg specification defines sort orders. We should consider this when 
> writing to an Iceberg table through Hive.
> See: https://iceberg.apache.org/spec/#sort-orders



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to