[
https://issues.apache.org/jira/browse/HIVE-26397?focusedWorklogId=792667&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-792667
]
ASF GitHub Bot logged work on HIVE-26397:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 19/Jul/22 12:56
Start Date: 19/Jul/22 12:56
Worklog Time Spent: 10m
Work Description: pvary commented on code in PR #3445:
URL: https://github.com/apache/hive/pull/3445#discussion_r924468260
##########
ql/src/java/org/apache/hadoop/hive/ql/metadata/HiveStorageHandler.java:
##########
@@ -346,6 +346,23 @@ default List<FieldSchema>
acidSortColumns(org.apache.hadoop.hive.ql.metadata.Tab
return Collections.emptyList();
}
+ /**
+ * Check if the underlying storage handler implementation supports sort
columns.
+ * @return true if the storage handler can support it
+ */
+ default boolean supportsSortColumns() {
+ return false;
+ }
+
+ /**
+ * Collect the columns that are used to sort the content of the data files
+ * @param table the table which is being sorted
+ * @return the list of columns that are used during data sorting
+ */
+ default List<FieldSchema>
sortColumns(org.apache.hadoop.hive.ql.metadata.Table table) {
+ return Collections.emptyList();
Review Comment:
Shall we throw an exception here, to find issues sooner?
Issue Time Tracking
-------------------
Worklog Id: (was: 792667)
Time Spent: 40m (was: 0.5h)
> Honour Iceberg sort orders when writing a table
> -----------------------------------------------
>
> Key: HIVE-26397
> URL: https://issues.apache.org/jira/browse/HIVE-26397
> Project: Hive
> Issue Type: Improvement
> Reporter: László Pintér
> Assignee: László Pintér
> Priority: Major
> Labels: pull-request-available
> Time Spent: 40m
> Remaining Estimate: 0h
>
> Iceberg specification defines sort orders. We should consider this when
> writing to an Iceberg table through Hive.
> See: https://iceberg.apache.org/spec/#sort-orders
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
