[
https://issues.apache.org/jira/browse/HIVE-22417?focusedWorklogId=796186&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-796186
]
ASF GitHub Bot logged work on HIVE-22417:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 28/Jul/22 20:57
Start Date: 28/Jul/22 20:57
Worklog Time Spent: 10m
Work Description: belugabehr commented on code in PR #3478:
URL: https://github.com/apache/hive/pull/3478#discussion_r932663609
##########
standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/ReplChangeManager.java:
##########
@@ -205,7 +205,7 @@ private ReplChangeManager(Configuration conf) throws
MetaException {
inited = true;
}
} catch (IOException e) {
- throw new MetaException(StringUtils.stringifyException(e));
+ throw new MetaException(e.getMessage());
Review Comment:
Ya, this ideally should just throw something other than a MetaException, but
it wasn't easy to fix like the other location. Log-and-Throw is a bad
practice; the code should do one or the other, not both. However, if you would
like, I can add a log along side the throw. Log-and-throw is probably a better
compromise.
The idea in general though is that MetaException is an Exception that gets
passed back to the client via the Thrift API. It should not be part of any of
the core Hive code,... Hive should simply log the exception (`error`) at the
Thrift service shim and throw MetaException back to the client.
Issue Time Tracking
-------------------
Worklog Id: (was: 796186)
Time Spent: 0.5h (was: 20m)
> Remove stringifyException from MetaStore
> ----------------------------------------
>
> Key: HIVE-22417
> URL: https://issues.apache.org/jira/browse/HIVE-22417
> Project: Hive
> Issue Type: Sub-task
> Components: Metastore, Standalone Metastore
> Affects Versions: 3.2.0
> Reporter: David Mollitor
> Assignee: David Mollitor
> Priority: Major
> Labels: pull-request-available
> Attachments: HIVE-22417.1.patch, HIVE-22417.2.patch
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
