[
https://issues.apache.org/jira/browse/HIVE-22417?focusedWorklogId=796596&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-796596
]
ASF GitHub Bot logged work on HIVE-22417:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 30/Jul/22 10:29
Start Date: 30/Jul/22 10:29
Worklog Time Spent: 10m
Work Description: zabetak commented on code in PR #3478:
URL: https://github.com/apache/hive/pull/3478#discussion_r933784608
##########
standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/ReplChangeManager.java:
##########
@@ -205,7 +205,7 @@ private ReplChangeManager(Configuration conf) throws
MetaException {
inited = true;
}
} catch (IOException e) {
- throw new MetaException(StringUtils.stringifyException(e));
+ throw new MetaException(e.getMessage());
Review Comment:
I am happy that we are on the same page :)
The first thing that came to my mind is doing this:
```java
throw new MetaException("Failed to create ReplChangeManager", e)
```
but it is not possible since MetaException class is generated by Thrift and
is missing the relevant constructor.
The next best thing was:
```java
throw (MetaException) new MetaException("Failed to create
ReplChangeManager").initCause(e);
```
but it is quite verbose so it feels natural to create a util and that's how
I think `MetaStoreUtils.newMetaException` was introduced.
Personally, I would prefer to use `MetaStoreUtils.newMetaException` here but
I understand that this is a bit subjective so I do not insist. The points you
raised make perfect sense so I am leaving the final decision up to you. You
have my `+1` on whatever you pick.
Issue Time Tracking
-------------------
Worklog Id: (was: 796596)
Time Spent: 1h 20m (was: 1h 10m)
> Remove stringifyException from MetaStore
> ----------------------------------------
>
> Key: HIVE-22417
> URL: https://issues.apache.org/jira/browse/HIVE-22417
> Project: Hive
> Issue Type: Sub-task
> Components: Metastore, Standalone Metastore
> Affects Versions: 3.2.0
> Reporter: David Mollitor
> Assignee: David Mollitor
> Priority: Major
> Labels: pull-request-available
> Attachments: HIVE-22417.1.patch, HIVE-22417.2.patch
>
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
