[ 
https://issues.apache.org/jira/browse/HIVE-26438?focusedWorklogId=796550&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-796550
 ]

ASF GitHub Bot logged work on HIVE-26438:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 30/Jul/22 00:39
            Start Date: 30/Jul/22 00:39
    Worklog Time Spent: 10m 
      Work Description: achennagiri opened a new pull request, #3487:
URL: https://github.com/apache/hive/pull/3487

   
   
   ### What changes were proposed in this pull request?
   This ticket is an improvement on 
https://issues.apache.org/jira/browse/HIVE-26426.  The canHandleQbForCbo() 
checks whether Calcite can handle the query or not and it returns null if the 
query can be handled; non-null reason string if it cannot be. 
   
   But currently, it returns an empty string if INFO Log is not enabled which 
should not be the case.
   Also, this is probably a performance optimization that is not needed and can 
be simplified. 
   
   ### Why are the changes needed?
   Simplify the code and improve the correctness.
   
   
   ### Does this PR introduce _any_ user-facing change?
   No.
   
   
   ### How was this patch tested?
   Unit tests.




Issue Time Tracking
-------------------

            Worklog Id:     (was: 796550)
    Remaining Estimate: 0h
            Time Spent: 10m

> Remove unnecessary optimization in canHandleQbForCbo() method
> -------------------------------------------------------------
>
>                 Key: HIVE-26438
>                 URL: https://issues.apache.org/jira/browse/HIVE-26438
>             Project: Hive
>          Issue Type: Bug
>            Reporter: Abhay
>            Assignee: Abhay
>            Priority: Major
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> This ticket is an improvement on 
> https://issues.apache.org/jira/browse/HIVE-26426.  The canHandleQbForCbo() 
> checks whether Calcite handle the query or not and it returns null if the 
> query can be handled; non-null reason string if it cannot be. 
> But currently, it returns an empty string if INFO Log is not enabled. This is 
> probably a performance optimization that is not needed and can be simplified. 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to