[
https://issues.apache.org/jira/browse/HIVE-26438?focusedWorklogId=797045&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-797045
]
ASF GitHub Bot logged work on HIVE-26438:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 01/Aug/22 21:45
Start Date: 01/Aug/22 21:45
Worklog Time Spent: 10m
Work Description: achennagiri commented on code in PR #3487:
URL: https://github.com/apache/hive/pull/3487#discussion_r934943226
##########
ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java:
##########
@@ -987,30 +985,29 @@ private static String canHandleQbForCbo(QueryProperties
queryProperties, HiveCon
// Not ok to run CBO, build error message.
String msg = "";
- if (verbose) {
- if (queryProperties.hasClusterBy()) {
- msg += "has cluster by; ";
- }
- if (queryProperties.hasDistributeBy()) {
- msg += "has distribute by; ";
- }
- if (queryProperties.hasSortBy() && queryProperties.hasLimit()) {
- msg += "has sort by with limit; ";
- }
- if (queryProperties.hasPTF()) {
- msg += "has PTF; ";
- }
- if (queryProperties.usesScript()) {
- msg += "uses scripts; ";
- }
- if (queryProperties.hasLateralViews()) {
- msg += "has lateral views; ";
- }
- if (msg.isEmpty()) {
- msg += "has some unspecified limitations; ";
- }
- msg = msg.substring(0, msg.length() - 2);
+ if (queryProperties.hasClusterBy()) {
Review Comment:
@jfsii I have made the changes accordingly. Let me know if there are any
issues
Issue Time Tracking
-------------------
Worklog Id: (was: 797045)
Time Spent: 40m (was: 0.5h)
> Remove unnecessary optimization in canHandleQbForCbo() method
> -------------------------------------------------------------
>
> Key: HIVE-26438
> URL: https://issues.apache.org/jira/browse/HIVE-26438
> Project: Hive
> Issue Type: Bug
> Reporter: Abhay
> Assignee: Abhay
> Priority: Major
> Labels: pull-request-available
> Time Spent: 40m
> Remaining Estimate: 0h
>
> This ticket is an improvement on
> https://issues.apache.org/jira/browse/HIVE-26426. The canHandleQbForCbo()
> checks whether Calcite handle the query or not and it returns null if the
> query can be handled; non-null reason string if it cannot be.
> But currently, it returns an empty string if INFO Log is not enabled. This is
> probably a performance optimization that is not needed and can be simplified.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
