[
https://issues.apache.org/jira/browse/HIVE-24483?focusedWorklogId=798403&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-798403
]
ASF GitHub Bot logged work on HIVE-24483:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 05/Aug/22 11:54
Start Date: 05/Aug/22 11:54
Worklog Time Spent: 10m
Work Description: zabetak commented on code in PR #3498:
URL: https://github.com/apache/hive/pull/3498#discussion_r938731653
##########
standalone-metastore/metastore-common/pom.xml:
##########
@@ -457,7 +457,7 @@
<goal>run</goal>
</goals>
<configuration>
-
<protocArtifact>${protobuf.group}:protoc:${protobuf-exc.version}</protocArtifact>
+
<protocArtifact>com.google.protobuf:protoc:3.21.4</protocArtifact>
Review Comment:
Should we use `${protobuf.version}` instead of hardcoding `3.21.4`?
##########
hbase-handler/src/java/org/apache/hadoop/hive/hbase/ResultWritable.java:
##########
@@ -26,8 +26,8 @@
import org.apache.hadoop.hbase.KeyValue;
import org.apache.hadoop.hbase.KeyValueUtil;
import org.apache.hadoop.hbase.client.Result;
-import org.apache.hadoop.hbase.protobuf.ProtobufUtil;
-import org.apache.hadoop.hbase.protobuf.generated.ClientProtos;
+import org.apache.hadoop.hbase.shaded.protobuf.ProtobufUtil;
+import org.apache.hadoop.hbase.shaded.protobuf.generated.ClientProtos;
Review Comment:
Do we know why these imports changed and point to shaded classes?
##########
hbase-handler/src/java/org/apache/hadoop/hive/hbase/ResultWritable.java:
##########
@@ -26,8 +26,8 @@
import org.apache.hadoop.hbase.KeyValue;
import org.apache.hadoop.hbase.KeyValueUtil;
import org.apache.hadoop.hbase.client.Result;
-import org.apache.hadoop.hbase.protobuf.ProtobufUtil;
-import org.apache.hadoop.hbase.protobuf.generated.ClientProtos;
+import org.apache.hadoop.hbase.shaded.protobuf.ProtobufUtil;
+import org.apache.hadoop.hbase.shaded.protobuf.generated.ClientProtos;
Review Comment:
Do we know why these imports changed and point to shaded classes?
##########
data/files/datasets/src_hbase/load.hive.sql:
##########
@@ -1,3 +1,5 @@
+DROP table if exists src_hbase_tmp;
Review Comment:
Seems reasonable but why we didn't do it before and we need to it now?
Issue Time Tracking
-------------------
Worklog Id: (was: 798403)
Time Spent: 3.5h (was: 3h 20m)
> Bump protobuf version to 3.21.1 (aarch64 support)
> -------------------------------------------------
>
> Key: HIVE-24483
> URL: https://issues.apache.org/jira/browse/HIVE-24483
> Project: Hive
> Issue Type: Improvement
> Reporter: Cameron Moberg
> Assignee: Ayush Saxena
> Priority: Minor
> Labels: pull-request-available
> Time Spent: 3.5h
> Remaining Estimate: 0h
>
> The following protoc version's used in hive is very old i.e. 2.5.0
> [https://repo.maven.apache.org/maven2/com/google/protobuf/protoc/] . The
> v2.5.0 does not have aarch64 support. But the AArch64 support started from
> v3.5.0 on-words in google's protobuf project release.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
