[
https://issues.apache.org/jira/browse/HIVE-24483?focusedWorklogId=798408&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-798408
]
ASF GitHub Bot logged work on HIVE-24483:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 05/Aug/22 12:07
Start Date: 05/Aug/22 12:07
Worklog Time Spent: 10m
Work Description: ayushtkn commented on code in PR #3498:
URL: https://github.com/apache/hive/pull/3498#discussion_r938747643
##########
data/files/datasets/src_hbase/load.hive.sql:
##########
@@ -1,3 +1,5 @@
+DROP table if exists src_hbase_tmp;
Review Comment:
Yeps, I am not sure, but my test failed once and in the next iteration when
I fixed it, It started giving me AlreadyExist exception for the table.
So, I added this. It doesn't occur on successive run when the test passes. I
thought better to have this. I can try removing it, If you feel so
##########
hbase-handler/src/java/org/apache/hadoop/hive/hbase/ResultWritable.java:
##########
@@ -26,8 +26,8 @@
import org.apache.hadoop.hbase.KeyValue;
import org.apache.hadoop.hbase.KeyValueUtil;
import org.apache.hadoop.hbase.client.Result;
-import org.apache.hadoop.hbase.protobuf.ProtobufUtil;
-import org.apache.hadoop.hbase.protobuf.generated.ClientProtos;
+import org.apache.hadoop.hbase.shaded.protobuf.ProtobufUtil;
+import org.apache.hadoop.hbase.shaded.protobuf.generated.ClientProtos;
Review Comment:
The Hbase tests were failing because they had one protobuf 2.5.0 reference
for some use case. So bugged the HBase folks and got that as a solution.
https://issues.apache.org/jira/browse/HBASE-21587?focusedCommentId=17575116&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17575116
Issue Time Tracking
-------------------
Worklog Id: (was: 798408)
Time Spent: 3h 40m (was: 3.5h)
> Bump protobuf version to 3.21.1 (aarch64 support)
> -------------------------------------------------
>
> Key: HIVE-24483
> URL: https://issues.apache.org/jira/browse/HIVE-24483
> Project: Hive
> Issue Type: Improvement
> Reporter: Cameron Moberg
> Assignee: Ayush Saxena
> Priority: Minor
> Labels: pull-request-available
> Time Spent: 3h 40m
> Remaining Estimate: 0h
>
> The following protoc version's used in hive is very old i.e. 2.5.0
> [https://repo.maven.apache.org/maven2/com/google/protobuf/protoc/] . The
> v2.5.0 does not have aarch64 support. But the AArch64 support started from
> v3.5.0 on-words in google's protobuf project release.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
