[
https://issues.apache.org/jira/browse/HIVE-26248?focusedWorklogId=800199&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-800199
]
ASF GitHub Bot logged work on HIVE-26248:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 12/Aug/22 07:24
Start Date: 12/Aug/22 07:24
Worklog Time Spent: 10m
Work Description: zhangbutao commented on code in PR #3312:
URL: https://github.com/apache/hive/pull/3312#discussion_r944184031
##########
ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/metastore/HiveMetaStoreAuthorizableEvent.java:
##########
@@ -71,4 +72,10 @@ protected HivePrivilegeObject
getHivePrivilegeObjectLocalUri(String uri) {
return new
HivePrivilegeObject(HivePrivilegeObject.HivePrivilegeObjectType.LOCAL_URI,
null, uri);
}
+ protected HivePrivilegeObject getHivePrivilegeObject(DataConnector
connector) {
+ return new
HivePrivilegeObject(HivePrivilegeObject.HivePrivilegeObjectType.DATACONNECTOR,
null,
+ connector.getName(), null, null,
HivePrivilegeObject.HivePrivObjectActionType.OTHER, null, null,
Review Comment:
`connector url` and `connector type` can not be added as a param here. At
present, we think all alter operations have same permission check logical, and
no need to specially check` connector url` or `connector type`.
Also, there is no related privilege types of `connector url` and
`connector type` in `HivePrivilegeObject `class:
https://github.com/apache/hive/blob/18501dd2e6f0c68038600b4dc69b7197a7827cbd/ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/HivePrivilegeObject.java#L108-L116
Issue Time Tracking
-------------------
Worklog Id: (was: 800199)
Time Spent: 1.5h (was: 1h 20m)
> Add data connector authorization on HMS server-side
> ---------------------------------------------------
>
> Key: HIVE-26248
> URL: https://issues.apache.org/jira/browse/HIVE-26248
> Project: Hive
> Issue Type: Sub-task
> Affects Versions: 4.0.0-alpha-1, 4.0.0-alpha-2
> Reporter: zhangbutao
> Assignee: zhangbutao
> Priority: Major
> Labels: pull-request-available
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
