[
https://issues.apache.org/jira/browse/HIVE-26443?focusedWorklogId=802423&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-802423
]
ASF GitHub Bot logged work on HIVE-26443:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 22/Aug/22 10:00
Start Date: 22/Aug/22 10:00
Worklog Time Spent: 10m
Work Description: veghlaci05 commented on code in PR #3513:
URL: https://github.com/apache/hive/pull/3513#discussion_r951247036
##########
ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/Worker.java:
##########
@@ -317,6 +318,15 @@ protected Boolean findNextCompactionAndExecute(boolean
collectGenericStats, bool
if ((runtimeVersion != null || ci.initiatorVersion != null) &&
!runtimeVersion.equals(ci.initiatorVersion)) {
LOG.warn("Worker and Initiator versions do not match. Worker: v{},
Initiator: v{}", runtimeVersion, ci.initiatorVersion);
}
+
+ if (StringUtils.isBlank(getPoolName()) &&
StringUtils.isNotBlank(ci.poolName)) {
+ LOG.warn("A timed out copmaction pool entry ({}) is picked up by one
of the default compaction pool workers.", ci);
+ }
+ if (StringUtils.isNotBlank(getPoolName()) &&
StringUtils.isNotBlank(ci.poolName) && !getPoolName().equals(ci.poolName)) {
Review Comment:
This normally should not happen at all, because the query filters the items
by pool name. However, I wanted to cover this case as well. If a labeled (not
the default) pool somehow gets a request assigned to another or the default
pool, I think it should not be processed.
- Simply skipping it could be problematic if the item gets returned by
`findNextCompact()` again and again. In this case this item will stuck in
`initiated` state, and if there's only one worker assigned to the pool, it will
even stuck the entire queue processing for that pool.
- Marking it as failed with a proper error message seemed to be more
convenient, which won't cause processing anomalies and is easier to track down
later.
Issue Time Tracking
-------------------
Worklog Id: (was: 802423)
Time Spent: 5h 20m (was: 5h 10m)
> Add priority queueing to compaction
> -----------------------------------
>
> Key: HIVE-26443
> URL: https://issues.apache.org/jira/browse/HIVE-26443
> Project: Hive
> Issue Type: New Feature
> Reporter: László Végh
> Assignee: László Végh
> Priority: Major
> Labels: pull-request-available
> Attachments: Pool based compaction queues.docx
>
> Time Spent: 5h 20m
> Remaining Estimate: 0h
>
> The details can be found in the attached design doc.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
