[
https://issues.apache.org/jira/browse/HIVE-26443?focusedWorklogId=803666&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-803666
]
ASF GitHub Bot logged work on HIVE-26443:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 25/Aug/22 14:43
Start Date: 25/Aug/22 14:43
Worklog Time Spent: 10m
Work Description: deniskuzZ commented on code in PR #3513:
URL: https://github.com/apache/hive/pull/3513#discussion_r955057810
##########
ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/Worker.java:
##########
@@ -317,6 +318,15 @@ protected Boolean findNextCompactionAndExecute(boolean
collectGenericStats, bool
if ((runtimeVersion != null || ci.initiatorVersion != null) &&
!runtimeVersion.equals(ci.initiatorVersion)) {
LOG.warn("Worker and Initiator versions do not match. Worker: v{},
Initiator: v{}", runtimeVersion, ci.initiatorVersion);
}
+
+ if (StringUtils.isBlank(getPoolName()) &&
StringUtils.isNotBlank(ci.poolName)) {
+ LOG.warn("A timed out copmaction pool entry ({}) is picked up by one
of the default compaction pool workers.", ci);
+ }
+ if (StringUtils.isNotBlank(getPoolName()) &&
StringUtils.isNotBlank(ci.poolName) && !getPoolName().equals(ci.poolName)) {
Review Comment:
that is a non-realistic situation, but still, this logic would confuse me,
why do I need to abandon a valid compaction request, it might be picked up by
another worker pool or even default one after the timeout. Note, I think
default pool size should be min 1.
Issue Time Tracking
-------------------
Worklog Id: (was: 803666)
Time Spent: 7h (was: 6h 50m)
> Add priority queueing to compaction
> -----------------------------------
>
> Key: HIVE-26443
> URL: https://issues.apache.org/jira/browse/HIVE-26443
> Project: Hive
> Issue Type: New Feature
> Reporter: László Végh
> Assignee: László Végh
> Priority: Major
> Labels: pull-request-available
> Attachments: Pool based compaction queues.docx
>
> Time Spent: 7h
> Remaining Estimate: 0h
>
> The details can be found in the attached design doc.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
