[ 
https://issues.apache.org/jira/browse/HIVE-26443?focusedWorklogId=805251&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-805251
 ]

ASF GitHub Bot logged work on HIVE-26443:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 31/Aug/22 14:16
            Start Date: 31/Aug/22 14:16
    Worklog Time Spent: 10m 
      Work Description: deniskuzZ commented on code in PR #3513:
URL: https://github.com/apache/hive/pull/3513#discussion_r959643998


##########
common/src/java/org/apache/hadoop/hive/conf/HiveConf.java:
##########
@@ -7036,4 +7036,15 @@ public void syncFromConf(HiveConf conf) {
       set(e.getKey(), e.getValue());
     }
   }
+
+  public List<RegexMatchingConfEntry> getMatchingEntries(Pattern regex) {
+    List<RegexMatchingConfEntry> matchingEntries = new ArrayList<>();
+    for (Map.Entry<String, String> entry : this) {
+      Matcher matcher = regex.matcher(entry.getKey());
+      if (matcher.matches()) {
+        matchingEntries.add(new RegexMatchingConfEntry(entry.getKey(), 
matcher));

Review Comment:
   i was only able to find `entry.getMatcher().group(0)`. Are we using 
`matches` on that matcher somewhere else?





Issue Time Tracking
-------------------

    Worklog Id:     (was: 805251)
    Time Spent: 12h 10m  (was: 12h)

> Add priority queueing to compaction
> -----------------------------------
>
>                 Key: HIVE-26443
>                 URL: https://issues.apache.org/jira/browse/HIVE-26443
>             Project: Hive
>          Issue Type: New Feature
>            Reporter: László Végh
>            Assignee: László Végh
>            Priority: Major
>              Labels: pull-request-available
>         Attachments: Pool based compaction queues.docx
>
>          Time Spent: 12h 10m
>  Remaining Estimate: 0h
>
> The details can be found in the attached design doc.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to