[
https://issues.apache.org/jira/browse/HIVE-26443?focusedWorklogId=805415&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-805415
]
ASF GitHub Bot logged work on HIVE-26443:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 01/Sep/22 07:03
Start Date: 01/Sep/22 07:03
Worklog Time Spent: 10m
Work Description: veghlaci05 commented on code in PR #3513:
URL: https://github.com/apache/hive/pull/3513#discussion_r960277912
##########
common/src/java/org/apache/hadoop/hive/conf/HiveConf.java:
##########
@@ -7036,4 +7036,15 @@ public void syncFromConf(HiveConf conf) {
set(e.getKey(), e.getValue());
}
}
+
+ public List<RegexMatchingConfEntry> getMatchingEntries(Pattern regex) {
+ List<RegexMatchingConfEntry> matchingEntries = new ArrayList<>();
+ for (Map.Entry<String, String> entry : this) {
+ Matcher matcher = regex.matcher(entry.getKey());
+ if (matcher.matches()) {
+ matchingEntries.add(new RegexMatchingConfEntry(entry.getKey(),
matcher));
Review Comment:
Only `entry.getMatcher().group(0)` used to times.
However, I think this method should be generic and return both the key, and
the corresponding matcher. The key is always required because it is used to
obtain the config value. In some cases, like the current, the matcher also can
be useful: We also need the poolname part of the key, and by using a grouped
regex it is already available in the matcher. This eliminates the need of
splitting/matching the key again in HiveServer2.
Issue Time Tracking
-------------------
Worklog Id: (was: 805415)
Time Spent: 12.5h (was: 12h 20m)
> Add priority queueing to compaction
> -----------------------------------
>
> Key: HIVE-26443
> URL: https://issues.apache.org/jira/browse/HIVE-26443
> Project: Hive
> Issue Type: New Feature
> Reporter: László Végh
> Assignee: László Végh
> Priority: Major
> Labels: pull-request-available
> Attachments: Pool based compaction queues.docx
>
> Time Spent: 12.5h
> Remaining Estimate: 0h
>
> The details can be found in the attached design doc.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
