[ 
https://issues.apache.org/jira/browse/HIVE-12237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14979519#comment-14979519
 ] 

Gopal V commented on HIVE-12237:
--------------------------------

I just rev'd the build today & noticed that at least the Q55 1000Gb LLAP demo 
has gone from ~700ms -> 1.96 seconds.

{code}
-    if (LlapIoImpl.LOGL.isInfoEnabled()) {
-      LlapIoImpl.LOG.info("Processing data for " + split.getPath());
-    }
+    LlapIoImpl.LOG.info("Processing data for {}", split.getPath());
+
{code}

Let's not jump to conclusions yet, because this is probably a single line which 
I might need to revert - to stop it from calling split.getPath() when INFO 
logging is disabled.

> Use slf4j as logging facade
> ---------------------------
>
>                 Key: HIVE-12237
>                 URL: https://issues.apache.org/jira/browse/HIVE-12237
>             Project: Hive
>          Issue Type: Task
>          Components: Logging
>    Affects Versions: 2.0.0
>            Reporter: Ashutosh Chauhan
>            Assignee: Ashutosh Chauhan
>             Fix For: 2.0.0
>
>         Attachments: HIVE-12237.1.patch, HIVE-12237.2.patch, 
> HIVE-12237.3.patch, HIVE-12237.4.patch, HIVE-12237.5.patch, 
> HIVE-12237.6.patch, HIVE-12237.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to