[
https://issues.apache.org/jira/browse/HIVE-12237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14979532#comment-14979532
]
Sergey Shelukhin commented on HIVE-12237:
-----------------------------------------
I think there may be many such lines in the codebase and no test will reliably
find them all. We should at least have code review of script that replaces
these and make sure methods are not replaced.
Overall I don't see why there's rush to remove the checks. This can be handled
on case by case basis. We should revert, and commit only the non-automated
parts.
Then if we do want to remove the checks, do the above.
> Use slf4j as logging facade
> ---------------------------
>
> Key: HIVE-12237
> URL: https://issues.apache.org/jira/browse/HIVE-12237
> Project: Hive
> Issue Type: Task
> Components: Logging
> Affects Versions: 2.0.0
> Reporter: Ashutosh Chauhan
> Assignee: Ashutosh Chauhan
> Fix For: 2.0.0
>
> Attachments: HIVE-12237.1.patch, HIVE-12237.2.patch,
> HIVE-12237.3.patch, HIVE-12237.4.patch, HIVE-12237.5.patch,
> HIVE-12237.6.patch, HIVE-12237.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
