[
https://issues.apache.org/jira/browse/HIVE-11495?focusedWorklogId=818390&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-818390
]
ASF GitHub Bot logged work on HIVE-11495:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 19/Oct/22 09:38
Start Date: 19/Oct/22 09:38
Worklog Time Spent: 10m
Work Description: deniskuzZ commented on code in PR #3656:
URL: https://github.com/apache/hive/pull/3656#discussion_r999193525
##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/TxnHandler.java:
##########
@@ -1023,6 +1023,7 @@ public void abortTxn(AbortTxnRequest rqst) throws
NoSuchTxnException, MetaExcept
long sourceTxnId = -1;
boolean isReplayedReplTxn =
TxnType.REPL_CREATED.equals(rqst.getTxn_type());
boolean isHiveReplTxn = rqst.isSetReplPolicy() &&
TxnType.DEFAULT.equals(rqst.getTxn_type());
+ String abrotMsg = (!rqst.isSetErrorMessage() && rqst.isSetTxnid())?
TxnErrorMsg.ABORT_QUERY.name():rqst.getErrorMessage();
Review Comment:
why do we need to check for the txnId here? In thrift, txnid is set as
mandatory
````
struct AbortTxnRequest {
1: required i64 txnid,
}
````
Issue Time Tracking
-------------------
Worklog Id: (was: 818390)
Time Spent: 1h 40m (was: 1.5h)
> Add aborted reason to transaction information.
> ----------------------------------------------
>
> Key: HIVE-11495
> URL: https://issues.apache.org/jira/browse/HIVE-11495
> Project: Hive
> Issue Type: Improvement
> Components: Metastore, Transactions
> Affects Versions: 1.0.0
> Reporter: Eugene Koifman
> Assignee: Simhadri Govindappa
> Priority: Major
> Labels: pull-request-available
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
> Should add TXNS.COMMENT field or something like that so that if the system
> aborts a transaction (due to timeout, for example) we can add a message to
> that effect to the aborted transaction.
> Another reason: Commit can fail due to a conflicting write from another txn
> (since HIVE-13395)
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
