[
https://issues.apache.org/jira/browse/HIVE-11495?focusedWorklogId=818396&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-818396
]
ASF GitHub Bot logged work on HIVE-11495:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 19/Oct/22 09:40
Start Date: 19/Oct/22 09:40
Worklog Time Spent: 10m
Work Description: deniskuzZ commented on code in PR #3656:
URL: https://github.com/apache/hive/pull/3656#discussion_r999198562
##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/TxnErrorMsg.java:
##########
@@ -0,0 +1,54 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hadoop.hive.metastore.txn;
+
+public enum TxnErrorMsg {
+ // Refer ErrorMsg.java
+ // 50000 to 59999: Txn Errors Codes.
+ NONE(50000, " None "),
+ ABORT_QUERY(50001, " Txn aborted by Abort Query Command "),
+ ABORT_TIMEOUT(50002, " Txn aborted due to heartbeat time-out after "),
+ ABORT_INTERRUPT(50003, " Txn aborted due to Interrupt Signal or user
aborted the query "),
+ ABORT_REPL_TXN(50004, " Replication:" +
+ "Abort all the allocated txns so that the mapped write ids are
referred as aborted ones. ");
+
+ private final int errorCode;
+ private final String txnErrorMsg;
+
+ TxnErrorMsg(int errorCode, String txnErrorMsg) {
+ this.errorCode = errorCode;
+ this.txnErrorMsg = txnErrorMsg;
+ }
+
+ public int getErrorCode() {
+ return errorCode;
+ }
+
+ public String getTxnErrorMsg() {
Review Comment:
is it used at all? how would it work? see
````
static private HiveException getHiveException(Exception e, String msg,
String logMsg) {
....
ErrorMsg errorMsg = ErrorMsg.getErrorMsg(e);
....
}
Issue Time Tracking
-------------------
Worklog Id: (was: 818396)
Time Spent: 1h 50m (was: 1h 40m)
> Add aborted reason to transaction information.
> ----------------------------------------------
>
> Key: HIVE-11495
> URL: https://issues.apache.org/jira/browse/HIVE-11495
> Project: Hive
> Issue Type: Improvement
> Components: Metastore, Transactions
> Affects Versions: 1.0.0
> Reporter: Eugene Koifman
> Assignee: Simhadri Govindappa
> Priority: Major
> Labels: pull-request-available
> Time Spent: 1h 50m
> Remaining Estimate: 0h
>
> Should add TXNS.COMMENT field or something like that so that if the system
> aborts a transaction (due to timeout, for example) we can add a message to
> that effect to the aborted transaction.
> Another reason: Commit can fail due to a conflicting write from another txn
> (since HIVE-13395)
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
