[
https://issues.apache.org/jira/browse/HIVE-26671?focusedWorklogId=821477&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-821477
]
ASF GitHub Bot logged work on HIVE-26671:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 28/Oct/22 14:53
Start Date: 28/Oct/22 14:53
Worklog Time Spent: 10m
Work Description: kasakrisz commented on code in PR #3706:
URL: https://github.com/apache/hive/pull/3706#discussion_r1008155409
##########
ql/src/java/org/apache/hadoop/hive/ql/plan/ReduceSinkDesc.java:
##########
@@ -430,6 +430,18 @@ public void setDistinctColumnIndices(
this.distinctColumnIndices = distinctColumnIndices;
}
+ public boolean hasADistinctColumnIndex() {
+ if (this.distinctColumnIndices == null) {
+ return false;
+ }
+ for (List<Integer> distinctColumnIndex : this.distinctColumnIndices) {
+ if (distinctColumnIndex != null && distinctColumnIndex.size() > 0) {
Review Comment:
nit
```
!distinctColumnIndex.empty()
```
Issue Time Tracking
-------------------
Worklog Id: (was: 821477)
Time Spent: 1.5h (was: 1h 20m)
> Incorrect results for group by/order by/limit query with 2 aggregates
> ---------------------------------------------------------------------
>
> Key: HIVE-26671
> URL: https://issues.apache.org/jira/browse/HIVE-26671
> Project: Hive
> Issue Type: Bug
> Components: Operators
> Reporter: Steve Carlin
> Assignee: Steve Carlin
> Priority: Major
> Labels: pull-request-available
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> Grabbed this query from the Impala test suite. It is a query run off of
> tpcds tables, but it's not really super special. You will need a lot of data
> to reproduce this, though.
> select
> l_orderkey,
> min(l_shipdate) as flt,
> count(distinct l_partkey) as cnl
> from lineitem
> group by l_orderkey order by l_orderkey limit 2;
> The issue is with the Top N Key operator optimizer. The Top N Key operator is
> the first operator after the Table Scan. The sort key is on both the
> l_orderkey and l_partkey columns, but this means that the second sort key
> might not be forwarded.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
