[
https://issues.apache.org/jira/browse/HIVE-26734?focusedWorklogId=825862&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-825862
]
ASF GitHub Bot logged work on HIVE-26734:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 14/Nov/22 18:17
Start Date: 14/Nov/22 18:17
Worklog Time Spent: 10m
Work Description: deniskuzZ commented on code in PR #3758:
URL: https://github.com/apache/hive/pull/3758#discussion_r1021906705
##########
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/writer/WriterBuilder.java:
##########
@@ -92,7 +92,10 @@ public HiveIcebergWriter build() {
long targetFileSize = PropertyUtil.propertyAsLong(table.properties(),
TableProperties.WRITE_TARGET_FILE_SIZE_BYTES,
TableProperties.WRITE_TARGET_FILE_SIZE_BYTES_DEFAULT);
+ boolean isWriteDeleteRow =
Boolean.parseBoolean(properties.getOrDefault("iceberg.write.deleterow",
"false"));
+
Schema dataSchema = table.schema();
+ Schema positionalDeleteSchema = isWriteDeleteRow ? dataSchema : null;
Review Comment:
not sure if the naming is good, it's actually a data schema. Maybe better to
just inline this ternary operator in Factory constructor?
##########
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/writer/WriterBuilder.java:
##########
@@ -92,7 +92,10 @@ public HiveIcebergWriter build() {
long targetFileSize = PropertyUtil.propertyAsLong(table.properties(),
TableProperties.WRITE_TARGET_FILE_SIZE_BYTES,
TableProperties.WRITE_TARGET_FILE_SIZE_BYTES_DEFAULT);
+ boolean isWriteDeleteRow =
Boolean.parseBoolean(properties.getOrDefault("iceberg.write.deleterow",
"false"));
+
Schema dataSchema = table.schema();
+ Schema positionalDeleteSchema = isWriteDeleteRow ? dataSchema : null;
Review Comment:
not sure if the naming is good, it's actually a data schema. Maybe better to
just inline this ternary operator in the Factory constructor?
Issue Time Tracking
-------------------
Worklog Id: (was: 825862)
Time Spent: 1h 20m (was: 1h 10m)
> Iceberg: Add an option to allow positional delete files without actual row
> data
> -------------------------------------------------------------------------------
>
> Key: HIVE-26734
> URL: https://issues.apache.org/jira/browse/HIVE-26734
> Project: Hive
> Issue Type: Improvement
> Reporter: Ayush Saxena
> Assignee: Ayush Saxena
> Priority: Major
> Labels: pull-request-available
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> Allow an option to have actual row data in the Iceberg PositionalDelete file
> as optional, to avoid reading and writing huge amount of actual row data
> during query executions.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
