[
https://issues.apache.org/jira/browse/HIVE-26734?focusedWorklogId=825918&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-825918
]
ASF GitHub Bot logged work on HIVE-26734:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 14/Nov/22 22:50
Start Date: 14/Nov/22 22:50
Worklog Time Spent: 10m
Work Description: deniskuzZ commented on code in PR #3758:
URL: https://github.com/apache/hive/pull/3758#discussion_r1022142481
##########
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/writer/HiveIcebergDeleteWriter.java:
##########
@@ -41,21 +41,31 @@
class HiveIcebergDeleteWriter extends HiveIcebergWriterBase {
private final GenericRecord rowDataTemplate;
+ private final boolean isWriteDeleteRow;
Review Comment:
@ayushtkn, I like the variant you've used in a tests:`skipRowData`, that
seems even better, up to you if you want to change it here.
Issue Time Tracking
-------------------
Worklog Id: (was: 825918)
Time Spent: 1h 40m (was: 1.5h)
> Iceberg: Add an option to allow positional delete files without actual row
> data
> -------------------------------------------------------------------------------
>
> Key: HIVE-26734
> URL: https://issues.apache.org/jira/browse/HIVE-26734
> Project: Hive
> Issue Type: Improvement
> Reporter: Ayush Saxena
> Assignee: Ayush Saxena
> Priority: Major
> Labels: pull-request-available
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
> Allow an option to have actual row data in the Iceberg PositionalDelete file
> as optional, to avoid reading and writing huge amount of actual row data
> during query executions.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
